Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

store/tikv:move definition of TiKVClient to store/tikv #22563

Merged
merged 5 commits into from
Jan 28, 2021
Merged

store/tikv:move definition of TiKVClient to store/tikv #22563

merged 5 commits into from
Jan 28, 2021

Conversation

AndreMouche
Copy link
Contributor

Signed-off-by: shirly AndreMouche@126.com

What problem does this PR solve?

Issue Number: part of #22513

Problem Summary:
store/tikv: move definition of TiKVClient to store/tikv

What is changed and how it works?

What's Changed:
store/tikv: move definition of TiKVClient to store/tikv

Check List

Tests

  • Unit test

Release note

  • No release note

@AndreMouche
store/tikv:move definitation of TiKVClient to store/tikv
f9613ba 
Signed-off-by: shirly <AndreMouche@126.com>
@AndreMouche
Copy link
Contributor Author

/cc @disksing @andelf

@AndreMouche
store/tikv:move definition of TiKVClient to store/tikv
5100320 
Signed-off-by: shirly <AndreMouche@126.com>
@ti-srebot
Copy link
Contributor

@andylokandy, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: sql-infra(slack).

@andylokandy andylokandy removed the sig/sql-infra SIG: SQL Infra label Jan 27, 2021
@andylokandy
Copy link
Contributor

/lgtm

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 27, 2021
@github-actions github-actions bot added the sig/sql-infra SIG: SQL Infra label Jan 27, 2021
@ti-srebot
Copy link
Contributor

@disksing, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: sql-infra(slack).

@disksing disksing added the status/can-merge Indicates a PR has been approved by a committer. label Jan 27, 2021
@ti-srebot
Copy link
Contributor

@disksing Oops! auto merge is restricted to Committers of the SIG.See the corresponding SIG page for more information. Related SIG: sql-infra(slack).

@disksing
Copy link
Contributor

/run-all-tests

@AndreMouche
Copy link
Contributor Author

/merge

@ti-srebot
Copy link
Contributor

@AndreMouche Oops! auto merge is restricted to Committers of the SIG.See the corresponding SIG page for more information. Related SIG: sql-infra(slack).

@AndreMouche AndreMouche added the sig/transaction SIG:Transaction label Jan 28, 2021
@AndreMouche
Copy link
Contributor Author

/merge

@ti-srebot
Copy link
Contributor

@AndreMouche Oops! This PR requires at least 2 LGTMs to merge. The current number of LGTM is 1

@AndreMouche
Copy link
Contributor Author

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit dd6b31a into pingcap:master Jan 28, 2021
@lance6716 lance6716 mentioned this pull request Feb 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@disksing disksing disksing approved these changes

@andylokandy andylokandy andylokandy approved these changes

Assignees
No one assigned
Labels
component/config component/store sig/sql-infra SIG: SQL Infra sig/transaction SIG:Transaction status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AndreMouche @ti-srebot @andylokandy @disksing