expression: support handle two collation cannot substituted to each other (#19036) #22582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
/run-all-tests |
ti-srebot
added
component/expression
contribution
|
@xiongjiwei you're already a collaborator in bot's repo. |
ti-srebot
added
status/LGT2
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
|
@ti-srebot merge failed. |
|
/merge |
|
/run-all-tests |
|
@ti-srebot merge failed. |
|
/merge |
|
/run-all-tests |
|
@ti-srebot merge failed. |
|
/merge |
|
/run-all-tests |
|
@ti-srebot merge failed. |
|
/merge |
|
/run-all-tests |
|
/merge |
|
/merge |
|
/run-all-tests |
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
|
@ti-srebot merge failed. |
|
/run-mybatis-test |
|
/merge |
|
/run-all-tests |
|
/merge |
|
/run-all-tests |
|
/merge |
|
/run-all-tests |
qw4990
approved these changes
Jan 28, 2021
|
@ti-srebot merge failed. |
|
/run-unit-test |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #19036 to release-4.0
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/22582After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
current collation strictness cannot handle situation if two collation cannot substituted to each other
e.g.
a != bin collationA,a=bin collationBandc=din collationA,c!=din collationBWhat is changed and how it works?
group collation by strictness, two collation can be substituted each other if they are in same group.
store strictnessship in a map with group id, collation group id in value is stricter than collation group id in key
Release note
CollationStrictnessto support incompatible strictnessship