expression: from_unixtime accept 64-bit integers

[TszKitLo40]

What problem does this PR solve?

Issue Number: close #22206

Problem Summary:

What is changed and how it works?

What's Changed:
from_unixtime accept 64-bit integers
How it Works:
evalFromUnixTime accepts 64-bit integers

Check List

Tests

• Unit test
• Integration test

Side effects

• Performance regression
  • Consumes more CPU
  • Consumes more MEM
• Breaking backward compatibility

Release note

• No release note

[TszKitLo40]

@morgo PTAL, but it seems that the test case select from_unixtime(1511247196661) is overflow.

[morgo]

@morgo PTAL, but it seems that the test case select from_unixtime(1511247196661) is overflow.

Yeah, I think this should return NULL still. Thanks for taking a look at this!

[TszKitLo40]

@morgo PTAL, but it seems that the test case select from_unixtime(1511247196661) is overflow.

Yeah, I think this should return NULL still. Thanks for taking a look at this!

This overflow is not caused by the time.Unix, it is caused in the function FromDate, it seems it is hard to know whether is will be overflow in this function.

[hawkingrei]

@TszKitLo40 Do you have time to finish this PR? If there is no reply within a week, I will close the PR and take over the job.

[TszKitLo40]

@TszKitLo40 Do you have time to finish this PR? If there is no reply within a week, I will close the PR and take over the job.

OK，I will try to finish it.

[TszKitLo40]

PTAL @hawkingrei

[sre-bot]

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/080b064faddaca788b7f926ed574557709b265c0

[morgo]

LGTM

MySQL 8.0 also fixes the functions UNIX_TIMESTAMP() and CONVERT_TZ(), but we can fork this to a separate issue. I suggest we close #22206 but keep #31786 open.

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• hawkingrei
• morgo

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[TszKitLo40]

/cc @hawkingrei

[xhebox]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: d60a298

[ti-chi-bot]

@TszKitLo40: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.