Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

store/tikv: move tikv driver out #22651

Merged
merged 10 commits into from
Feb 2, 2021
Merged

store/tikv: move tikv driver out #22651

merged 10 commits into from
Feb 2, 2021

Conversation

disksing
Copy link
Contributor

@disksing disksing commented Feb 1, 2021

Signed-off-by: disksing i@disksing.com

What problem does this PR solve?

Move tikv.Driver out of store/tikv to resolve dependency on tidb.

Part of #22513

What is changed and how it works?

What's Changed:

  • move tikv.Driver to store.TiKVDriver.
  • create store.tikvStore to wrap tikv.KVStore and provide functions tidb need.
  • tests in store/tikv use KVStore to test instead of kv.Storage.

Check List

Tests

  • Unit test

Release note

  • No release note

@disksing
store/tikv: move tikv driver out
6b40dc2 
Signed-off-by: disksing <i@disksing.com>
@disksing
update tools
10806bc 
Signed-off-by: disksing <i@disksing.com>
@disksing
update tests
db6d377 
Signed-off-by: disksing <i@disksing.com>
@disksing
Copy link
Contributor Author

disksing commented Feb 1, 2021

/run-all-tests

@github-actions github-actions bot added the sig/sql-infra SIG: SQL Infra label Feb 1, 2021
@disksing disksing marked this pull request as draft February 1, 2021 23:10
@disksing
fix test
111dedc 
Signed-off-by: disksing <i@disksing.com>
@disksing
fix test
38f3e62 
Signed-off-by: disksing <i@disksing.com>
@disksing
fix test
03b5277 
Signed-off-by: disksing <i@disksing.com>
@disksing
Copy link
Contributor Author

disksing commented Feb 2, 2021

/run-all-tests

@disksing
Copy link
Contributor Author

disksing commented Feb 2, 2021

/run-e2e-test

@disksing
fix test
64ead7a 
Signed-off-by: disksing <i@disksing.com>
@disksing
Copy link
Contributor Author

disksing commented Feb 2, 2021

/run-all-tests

@disksing
Copy link
Contributor Author

disksing commented Feb 2, 2021

/run-integration-copr-test

@disksing disksing marked this pull request as ready for review February 2, 2021 06:34
youjiali1995
youjiali1995 approved these changes Feb 2, 2021
View reviewed changes
Copy link
Contributor

@youjiali1995 youjiali1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

AndreMouche
AndreMouche approved these changes Feb 2, 2021
View reviewed changes
Copy link
Contributor

@AndreMouche AndreMouche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndreMouche
Copy link
Contributor

/merge

@AndreMouche
Copy link
Contributor

/merge

1 similar comment
@andylokandy
Copy link
Contributor

/merge

@andylokandy andylokandy added the status/can-merge Indicates a PR has been approved by a committer. label Feb 2, 2021
@AndreMouche AndreMouche merged commit 6c1a6dd into pingcap:master Feb 2, 2021
@disksing disksing deleted the driver branch February 2, 2021 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youjiali1995 youjiali1995 youjiali1995 approved these changes

@AndreMouche AndreMouche AndreMouche approved these changes

@andylokandy andylokandy Awaiting requested review from andylokandy

Assignees
No one assigned
Labels
component/store sig/sql-infra SIG: SQL Infra sig/transaction SIG:Transaction status/can-merge Indicates a PR has been approved by a committer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@disksing @AndreMouche @andylokandy @youjiali1995