Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: restore the old Execute API only for the test #22692

Merged
merged 4 commits into from
Feb 5, 2021

Conversation

AilinKid
Copy link
Contributor

@AilinKid AilinKid commented Feb 3, 2021

Signed-off-by: AilinKid 314806019@qq.com

What problem does this PR solve?

Issue Number: close #pingcap/tidb-test#1152
Related PR #22647

Problem Summary:

What is changed and how it works?

What's Changed:
Since the tests widely use the old API Execute, keep it unchanged for now can reduce the cherry-pick conflicts.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • No code

Release note

  • cmd: restore the old Execute API only for the test.

Signed-off-by: AilinKid <314806019@qq.com>
Copy link
Contributor

@xhebox xhebox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 3, 2021
@AilinKid
Copy link
Contributor Author

AilinKid commented Feb 4, 2021

PTAL @tiancaiamao

@AilinKid
Copy link
Contributor Author

AilinKid commented Feb 4, 2021

@wshwsh12

@AilinKid AilinKid requested a review from morgo February 5, 2021 03:48
Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Feb 5, 2021
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Feb 5, 2021
@wshwsh12
Copy link
Contributor

wshwsh12 commented Feb 5, 2021

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 5, 2021
@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 22747

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 006e2fc into pingcap:master Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants