-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
store/tikv_driver: move gcworker into tikv_driver #22698
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: shirly <AndreMouche@126.com>
disksing
reviewed
Feb 3, 2021
Signed-off-by: shirly <AndreMouche@126.com>
Signed-off-by: shirly <AndreMouche@126.com>
disksing
previously approved these changes
Feb 4, 2021
andylokandy
previously approved these changes
Feb 4, 2021
ti-srebot
previously approved these changes
Feb 4, 2021
/merge |
ti-srebot
added
the
status/can-merge
Indicates a PR has been approved by a committer.
label
Feb 4, 2021
Your auto merge job has been accepted, waiting for:
|
/run-all-tests |
1 similar comment
/run-all-tests |
@AndreMouche merge failed. |
/merge |
2 similar comments
/merge |
/merge |
/run-all-tests |
@AndreMouche merge failed. |
/run-all-tests |
@AndreMouche merge failed. |
/run-all-tests |
@AndreMouche merge failed. |
/merge |
Your auto merge job has been accepted, waiting for:
|
/run-all-tests |
@AndreMouche merge failed. |
Signed-off-by: shirly <AndreMouche@126.com>
AndreMouche
dismissed stale reviews from ti-srebot, andylokandy, and disksing
via
February 5, 2021 08:08
4a0f127
Signed-off-by: shirly <AndreMouche@126.com>
andylokandy
approved these changes
Feb 5, 2021
/merge |
Your auto merge job has been accepted, waiting for:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
sig/transaction
SIG:Transaction
status/can-merge
Indicates a PR has been approved by a committer.
status/LGT2
Indicates that a PR has LGTM 2.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: AndreMouche
What problem does this PR solve?
gcworker
andenableGC
now is part oftikv.KVStore
,lets move it totikvStore
in tikv_driverPart of #22513
Check List
Tests
Release note