Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: add tests for empty query hang #22740

Merged
merged 4 commits into from
Feb 11, 2021

Conversation

morgo
Copy link
Contributor

@morgo morgo commented Feb 5, 2021

What problem does this PR solve?

Issue Number: related to #22738

Problem Summary:

This adds a test to master for the bug fixed in #22738

Master is not affected, but it seems possible that someone could accidentally remove this code not realizing what it does in future.

What is changed and how it works?

What's Changed:

new tests only.

Related changes

  • None

Check List

Tests

  • Unit test
  • No code

Side effects

  • None

Release note

  • No release note

@github-actions github-actions bot added the sig/sql-infra SIG: SQL Infra label Feb 5, 2021
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 8, 2021
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Feb 8, 2021
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Feb 8, 2021
@jackysp
Copy link
Member

jackysp commented Feb 8, 2021

/approve
/merge

@jackysp
Copy link
Member

jackysp commented Feb 8, 2021

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 8, 2021
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@morgo merge failed.

@morgo
Copy link
Contributor Author

morgo commented Feb 8, 2021

/run-unit-test

@jackysp
Copy link
Member

jackysp commented Feb 11, 2021

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit d6a2b9a into pingcap:master Feb 11, 2021
@morgo morgo deleted the add-tests-for-timeout branch February 11, 2021 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants