Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: Treat non null Enum as bool true #22777

Closed
wants to merge 1 commit into from
Closed

expression: Treat non null Enum as bool true #22777

wants to merge 1 commit into from

Conversation

tohghua
Copy link

@tohghua tohghua commented Feb 16, 2021 •
edited
Loading

#22717: Wrong enum calculation result in where condition

Release Note:

  • Treat non null Enum as bool true in expressions

@tohghua tohghua requested a review from a team as a code owner February 16, 2021 10:44
@tohghua tohghua requested review from qw4990 and removed request for a team February 16, 2021 10:44
@CLAassistant
Copy link

CLAassistant commented Feb 16, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ti-srebot ti-srebot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label Feb 16, 2021
@sre-bot
Copy link
Contributor

sre-bot commented Feb 16, 2021

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

@tohghua tohghua changed the title expression: Treat non null Enum as bool true (#22717) expression: Treat non null Enum as bool true Feb 16, 2021
@XuHuaiyu
Copy link
Contributor

Hi, @tohghua
This PR is duplicated with #22785.
Can you check other issues and pick one to fix?

@XuHuaiyu XuHuaiyu closed this Feb 22, 2021
@tohghua tohghua deleted the issue22717 branch February 22, 2021 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 Awaiting requested review from qw4990

Assignees
No one assigned
Labels
component/expression first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tohghua @CLAassistant @sre-bot @XuHuaiyu @ti-srebot