planner: let tikv know primary prefix columns info #22829
Conversation
lysu
requested review from
wshwsh12 and
lzmhhh123
and removed request for
a team
|
need merge pingcap/tipb#214 first |
lysu
changed the title
lysu
changed the title
lysu
changed the title
github-actions
bot
added
sig/execution
|
/run-check_dev_2 tikv=pr/9670 |
|
LGTM |
|
/lgtm |
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
ti-chi-bot
added
status/LGT2
|
/merge |
|
@tangenta: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. Commit hash: c7971ce2e037b4abe4c49b980d1124911058a129
|
ti-chi-bot
added
status/can-merge
|
@lysu: Your PR has out-of-dated, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
need merge tikv/tikv#9670 first to make default run-all-tests can pass |
|
/run-sqllogic-test1 tidb-test=pr/1164 |
2 similar comments
|
/run-sqllogic-test1 tidb-test=pr/1164 |
|
/run-sqllogic-test1 tidb-test=pr/1164 |
|
/run-all-tests |
|
@ti-chi-bot update this PR |
Signed-off-by: lysu <sulifx@gmail.com>
Signed-off-by: lysu <sulifx@gmail.com>
Signed-off-by: lysu <sulifx@gmail.com>
Signed-off-by: lysu <sulifx@gmail.com>
ti-chi-bot
removed
the
status/can-merge
Signed-off-by: lysu <sulifx@gmail.com> <!-- Thank you for contributing to TiKV! If you haven't already, please read TiKV's [CONTRIBUTING](https://github.com/tikv/tikv/blob/master/CONTRIBUTING.md) document. If you're unsure about anything, just ask; somebody should be along to answer within a day or two. PR Title Format: 1. module [, module2, module3]: what's changed 2. *: what's changed If you want to open the **Challenge Program** pull request, please use the following template: https://raw.githubusercontent.com/tikv/.github/master/.github/PULL_REQUEST_TEMPLATE/challenge-program.md You can use it with query parameters: https://github.com/tikv/tikv/compare/master...${you branch}?template=challenge-program.md --> ### What problem does this PR solve? Issue Number: close pingcap/tidb#22811 Problem Summary: tikv will avoid read value when required column in common handle but common handle's columns maybe not contain full columns value (like `primary key(c(1))`) ### What is changed and how it works? What's Changed: read kv's value when required column in common handle is the prefix of column need merge pingcap/tidb#22829 first ### Related changes - n/a ### Check List <!--REMOVE the items that are not applicable--> Tests <!-- At least one of them must be included. --> - Integration test(WIP) Side effects - n/a ### Release note <!-- bugfixes or new feature need a release note --> - no release note <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/tikv/tikv/9670) <!-- Reviewable:end -->
|
/run-check_dev_2 tikv=pr/9670 |
|
LGTM |
|
@coocood: Please use If you have approved this PR, please ignore this reply. This reply is being used as a temporary reply during the migration of the new bot and will be removed on April 1. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
/merge |
|
@lysu: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. Commit hash: ff6f930
|
ti-chi-bot
added
the
status/can-merge
|
@lysu: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: lysu sulifx@gmail.com
What problem does this PR solve?
Issue Number: ref #22811
need fix in tikv
Problem Summary:
tikv now didn't read value even if key only contain prefix of column value when primary key's column is
cb(1)What is changed and how it works?
What's Changed, How it Works:
set field for pingcap/tipb#214
to put prefixed info down to tikv to let it read value even due to key only contains prefix
and handle it in tikv tikv/tikv#9670
Related changes
Check List
Tests
Side effects
Release note
This change is