Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: migrate part of ddl package code from Execute/ExecRestricted to safe API (1) (#22670) #23081

Merged
merged 2 commits into from
Mar 5, 2021

Conversation

AilinKid
Copy link
Contributor

@AilinKid AilinKid commented Mar 3, 2021

Signed-off-by: AilinKid 314806019@qq.com

What problem does this PR solve?

cherry-pick #22670

Release note

  • migrate part of ddl package code from Execute/ExecRestricted to safe API

…safe API (1) (pingcap#22670)

Signed-off-by: AilinKid <314806019@qq.com>
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 3, 2021
@AilinKid
Copy link
Contributor Author

AilinKid commented Mar 3, 2021

/run-all-tests

@AilinKid AilinKid requested a review from xhebox March 3, 2021 10:21
@AilinKid AilinKid assigned tangenta and unassigned tangenta Mar 3, 2021
@AilinKid AilinKid requested a review from tangenta March 3, 2021 10:21
@xhebox
Copy link
Contributor

xhebox commented Mar 4, 2021

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 4, 2021
@tangenta
Copy link
Contributor

tangenta commented Mar 5, 2021

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • tangenta
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 5, 2021
@AilinKid
Copy link
Contributor Author

AilinKid commented Mar 5, 2021

/merge

@ti-chi-bot
Copy link
Member

@AilinKid: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7e528d1

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 5, 2021
@ti-chi-bot ti-chi-bot merged commit 25d7f39 into pingcap:release-2.1 Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants