util, types: don't let SPM be affected by charset #23161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
added
the
size/XS
|
/run-check_dev_2 parser=pr/1184 |
|
/rebuild parser=pr/1184 |
|
/sig planner |
|
/cc @qw4990 |
|
/cc @eurekaka |
eurekaka
reviewed
Mar 12, 2021
eurekaka
added
priority/release-blocker
ti-chi-bot
added
size/S
eurekaka
reviewed
Mar 12, 2021
|
Merge canceled because a new commit is pushed. |
ti-chi-bot
added
size/L
ti-chi-bot
removed
the
needs-rebase
|
/run-all-tests |
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
|
/run-all-tests |
XuHuaiyu
reviewed
Mar 12, 2021
session/bootstrap_test.go
Outdated
| @@ -545,9 +553,10 @@ func (s *testBootstrapSuite) TestUpdateBindInfo(c *C) { | |||
| bindCase.bindText, | |||
| bindCase.db, | |||
| ) | |||
| fmt.Println("[sql]", sql) | |||
session/bootstrap.go
Outdated
| @@ -543,12 +544,13 @@ var ( | |||
| // We will redo upgradeToVer58 in upgradeToVer64, it is skipped here. | |||
| upgradeToVer59, | |||
| upgradeToVer60, | |||
| upgradeToVer61, | |||
| // We will redo upgradeToVer61 in upgradeToVer6, it is skipped here. | |||
|
/run-all-tests |
|
/lgtm |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Mar 12, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #23295 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Different default charsets in different drivers(or versions) make SQL bind cannot work.
So we don't let SPM be affected by charset.
We add a flag
RestoreStringWithoutCharsetto control this.Need to merge parser pr first
Related changes
Check List
Tests
Side effects
Release note