Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: set right null flag for constant value #23172

Merged
merged 5 commits into from
Mar 12, 2021

Conversation

fzhedu
Copy link
Contributor

@fzhedu fzhedu commented Mar 8, 2021

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary: #14912 did not thoroughly set right null flag for constant value, so this PR aims to do that. It has to keep the expression and schema item consistent. For example: select -1 from t; the expression (-1) is not null, and its returning schema contains a not-null column. As a result, plan_to_pb will get consistent plan, avoiding errors in TiFlash.

What is changed and how it works?

Proposal: xxx

What's Changed:

we set null flag for constants in two aspects:

  1. a constant item;
  2. folding constants.

How it Works:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Integration test (the existing typeinfer_test cover the goal, which checks the schema and expression.)

Release note

  • No release note

@fzhedu fzhedu requested review from a team as code owners March 8, 2021 08:58
@fzhedu fzhedu requested review from XuHuaiyu and removed request for a team March 8, 2021 08:58
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 8, 2021
@fzhedu fzhedu added type/bugfix This PR fixes a bug. sig/planner SIG: Planner labels Mar 8, 2021
@fzhedu
Copy link
Contributor Author

fzhedu commented Mar 8, 2021

/cc @lzmhhh123 @leiysky @windtalker

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 12, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hanfei1991
  • lzmhhh123

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 12, 2021
@hanfei1991 hanfei1991 self-assigned this Mar 12, 2021
@hanfei1991
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d8a1eb9

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 12, 2021
@ti-chi-bot
Copy link
Member

@fzhedu: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 920b70d into pingcap:master Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants