-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner, table: set PrimaryPrefixColumnIds correctly #23250
planner, table: set PrimaryPrefixColumnIds correctly #23250
Conversation
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we can remove these lines:
tidb/planner/core/plan_to_pb.go
Lines 200 to 202 in 6bd6df7
if p.Table.IsCommonHandle { | |
tsExec.PrimaryPrefixColumnIds = tables.PrimaryPrefixColumnIDs(p.Table) | |
} |
Should we add some tests to make sure ADD INDEX
and RECOVER INDEX
works?
/lgtm |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
d4a85ec
to
e2c46dc
Compare
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 10403d2
|
Related to #22811. |
@wjhuang2016: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: wjhuang2016 huangwenjun1997@gmail.com
What problem does this PR solve?
Problem Summary:
Some usages of
BuildTableScanFromInfos()
doesn't set PrimaryPrefixColumnIds.What is changed and how it works?
set PrimaryPrefixColumnIds in BuildTableScanFromInfos().
Related changes
Check List
Tests
Side effects
Release note