region cache: prevent send read request to learner peer #23272
Conversation
Signed-off-by: nolouch <nolouch@gmail.com>
|
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
ti-chi-bot
added
the
size/S
|
No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md |
Signed-off-by: nolouch <nolouch@gmail.com>
| for i := 0; i < rs.accessStoreNum(TiKVOnly); i++ { | ||
| store, peer, accessIdx, storeIdx = r.getKvStorePeer(rs, rs.kvPeer(followerStoreSeed, op)) | ||
| if peer.Role == metapb.PeerRole_Learner { | ||
| followerStoreSeed++ | ||
| continue | ||
| } | ||
| return | ||
| } | ||
| return |
There was a problem hiding this comment.
Maybe doing it in kvPeer() will be clearer? kvPeer() is only called by AnyStorePeer.
nolouch
added
the
do-not-merge/hold
Signed-off-by: nolouch nolouch@gmail.com
What problem does this PR solve?
ref #23271
Problem Summary:
What is changed and how it works?
What's Changed: the session variable only says leader and follower, so we do not send to the learner at first. and in the normal TiKV cluster, learner only is a intermediate state.
How it Works: skip the peer role is learner
Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Release note