Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store/tikv: remove kv.Version from package store/tikv #23282

Merged
merged 6 commits into from
Mar 13, 2021

Conversation

AndreMouche
Copy link
Contributor

@AndreMouche AndreMouche commented Mar 12, 2021

Signed-off-by: AndreMouche

What problem does this PR solve?

This PR removes the usage of kv.Version from tikv package
Part of #22513

Check List

Tests

  • Unit test

Release note

  • No release note

Signed-off-by: shirly <AndreMouche@126.com>
@AndreMouche AndreMouche added the sig/transaction SIG:Transaction label Mar 12, 2021
@AndreMouche AndreMouche requested a review from a team as a code owner March 12, 2021 07:58
@AndreMouche AndreMouche requested review from lzmhhh123 and removed request for a team March 12, 2021 07:58
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 12, 2021
@github-actions github-actions bot added the sig/execution SIG execution label Mar 12, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 12, 2021
store/tikv/txn.go Outdated Show resolved Hide resolved
store/tikv/snapshot.go Outdated Show resolved Hide resolved
store/tikv/kv.go Outdated Show resolved Hide resolved
Signed-off-by: shirly <AndreMouche@126.com>
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • andylokandy
  • disksing

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 12, 2021
Signed-off-by: shirly <AndreMouche@126.com>
@AndreMouche
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 561b671

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 13, 2021
@ti-chi-bot
Copy link
Member

@AndreMouche: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit b534ec7 into pingcap:master Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution sig/transaction SIG:Transaction size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants