Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: deprecate alter-primary-key configuration (#23270) #23394

Merged
merged 2 commits into from
Mar 18, 2021
Merged

*: deprecate alter-primary-key configuration (#23270) #23394

merged 2 commits into from
Mar 18, 2021

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Mar 18, 2021 •
edited
Loading

cherry-pick #23270 to release-5.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/23394

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/23394:release-5.0-411dba25b165

What problem does this PR solve?

Problem Summary:

This PR removes the config alter-primary-key. To alter the primary key, the users should use the NONCLUSTERED syntax instead to create a table.

What is changed and how it works?

What's Changed: Omitted.

How it Works: Omitted.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn!

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • Breaking backward compatibility

Release note

  • The configuration alter-primary-key is deprecated. Use NONCLUSTERED instead.

@ti-srebot
cherry pick pingcap#23270 to release-5.0
ba7ebc2 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot requested review from a team as code owners March 18, 2021 07:18
@ti-srebot ti-srebot requested review from lzmhhh123 and removed request for a team March 18, 2021 07:18
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot mentioned this pull request Mar 18, 2021
Merged
@ti-srebot ti-srebot added component/config component/expression component/statistics sig/execution SIG execution sig/sql-infra SIG: SQL Infra size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/5.0-cherry-pick labels Mar 18, 2021
@ti-srebot ti-srebot added this to the v5.0.0 ga milestone Mar 18, 2021
@ti-srebot
Copy link
Contributor Author

@tangenta you're already a collaborator in bot's repo.

@lysu
Copy link
Contributor

lysu commented Mar 18, 2021

need merge with https://github.com/pingcap/tidb-test/pull/1173

@lysu
Copy link
Contributor

lysu commented Mar 18, 2021

/run-all-tests tidb-test=pr/1173

@lysu
Copy link
Contributor

lysu commented Mar 18, 2021

/run-unit-test

@lysu
Copy link
Contributor

lysu commented Mar 18, 2021

/LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 18, 2021
@coocood
Copy link
Member

coocood commented Mar 18, 2021

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • coocood
  • lysu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot removed the status/LGT1 Indicates that a PR has LGTM 1. label Mar 18, 2021
@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Mar 18, 2021
@coocood
Copy link
Member

coocood commented Mar 18, 2021

/run-unit-test

@coocood
Copy link
Member

coocood commented Mar 18, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ba7ebc2

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 18, 2021
@coocood
Copy link
Member

coocood commented Mar 18, 2021

/run-common-test

@coocood
Copy link
Member

coocood commented Mar 18, 2021

/run-integration-common-test

@coocood
Copy link
Member

coocood commented Mar 18, 2021

/run-check_dev

@coocood
Copy link
Member

coocood commented Mar 18, 2021

/run-all-tests

@ti-chi-bot ti-chi-bot merged commit c822691 into pingcap:release-5.0 Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzmhhh123 lzmhhh123 Awaiting requested review from lzmhhh123

@coocood coocood Awaiting requested review from coocood

@eurekaka eurekaka Awaiting requested review from eurekaka

@jackysp jackysp Awaiting requested review from jackysp

@lysu lysu Awaiting requested review from lysu

@wjhuang2016 wjhuang2016 Awaiting requested review from wjhuang2016

Assignees

@tangenta tangenta

Labels
component/config component/expression component/statistics sig/execution SIG execution sig/sql-infra SIG: SQL Infra size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/5.0-cherry-pick
Projects
None yet
Milestone
v5.0.0 ga
Development

Successfully merging this pull request may close these issues.
5 participants
@ti-srebot @lysu @coocood @ti-chi-bot @tangenta