Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: fix update panic on join having statement #23554

Merged
merged 4 commits into from
Mar 26, 2021
Merged

executor: fix update panic on join having statement #23554

merged 4 commits into from
Mar 26, 2021

Conversation

lzmhhh123
Copy link
Contributor

Signed-off-by: lzmhhh123 lzmhhh123@gmail.com

What problem does this PR solve?

Issue Number: close #23553

What is changed and how it works?

How it Works: when pruning projection, for the two continuous projections, the top one has been pruning, but the below one has a different schema. Then it causes their parent operator recognising some schema columns as unused columns, then cause update panic.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • Performance regression
    • Consumes more CPU

Release note

  • fix update panic on join having statement.

@lzmhhh123
executor: fix update panic on join having statement
756b493 
Signed-off-by: lzmhhh123 <lzmhhh123@gmail.com>
@lzmhhh123 lzmhhh123 requested review from a team as code owners March 25, 2021 09:54
@lzmhhh123 lzmhhh123 requested review from wshwsh12 and eurekaka and removed request for a team March 25, 2021 09:54
@lzmhhh123 lzmhhh123 added the type/bugfix This PR fixes a bug. label Mar 25, 2021
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 25, 2021
@XuHuaiyu
Copy link
Contributor

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 25, 2021
@github-actions github-actions bot added the sig/execution SIG execution label Mar 25, 2021
Reminiscent
Reminiscent approved these changes Mar 26, 2021
View reviewed changes
Copy link
Contributor

@Reminiscent Reminiscent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

@Reminiscent: Please use /LGTM instead of LGTM when you want to approve the pull request by comment.
If you use the GitHub review feature, please approve the PR directly, the comment will not take effect in the GitHub review feature.
If you have any qustions please refer to lgtm command help or lgtm plugin design.

If you have approved this PR, please ignore this reply. This reply is being used as a temporary reply during the migration of the new bot and will be removed on April 1.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Reminiscent
  • XuHuaiyu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 26, 2021
@Reminiscent
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8d5e498

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 26, 2021
@lzmhhh123
Copy link
Contributor Author

/merge

@ichn-hu ichn-hu mentioned this pull request Mar 26, 2021
Closed
@ti-chi-bot ti-chi-bot merged commit 82bfdca into pingcap:master Mar 26, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 26, 2021
@lzmhhh123 @ti-srebot
cherry pick pingcap#23554 to release-4.0
15024a8 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 26, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #23575

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 26, 2021
@lzmhhh123 @ti-srebot
cherry pick pingcap#23554 to release-5.0
f456a51 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 26, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #23576

ti-chi-bot pushed a commit that referenced this pull request Mar 26, 2021
@ti-srebot
executor: fix update panic on join having statement (#23554) (#23576)
14d47e3
@lzmhhh123 lzmhhh123 deleted the bug-fix/fix_update_panic branch March 26, 2021 06:57
ti-chi-bot pushed a commit that referenced this pull request May 8, 2021
@ti-srebot
executor: fix update panic on join having statement (#23554) (#23575)
e431c06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Reminiscent Reminiscent Reminiscent approved these changes

@wshwsh12 wshwsh12 Awaiting requested review from wshwsh12

@eurekaka eurekaka Awaiting requested review from eurekaka

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.0 sig/execution SIG execution size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update single table with join having panic
5 participants
@lzmhhh123 @XuHuaiyu @ti-chi-bot @Reminiscent @ti-srebot