Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

execution: no slow query log after dumpTableStatColSizeToKV #23555

Closed
wants to merge 1 commit into from
Closed

execution: no slow query log after dumpTableStatColSizeToKV #23555

wants to merge 1 commit into from

Conversation

jianzhiyao
Copy link
Contributor

@jianzhiyao jianzhiyao commented Mar 25, 2021 •
edited
Loading

What problem does this PR solve?

Issue Number: close xxx

Problem Summary:

What is changed and how it works?

no slow query log after dumpTableStatCountToKV

How it Works:
query sql with ExecuteInternal

Check List

Tests

  • No code

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM

Release note

  • execution: no slow query log after dumpTableStatCountToKV

@jianzhiyao jianzhiyao requested a review from a team as a code owner March 25, 2021 10:15
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@jianzhiyao jianzhiyao requested review from hanfei1991 and removed request for a team March 25, 2021 10:15
@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 25, 2021
@jianzhiyao jianzhiyao changed the title wip: execution: no slow query log after dumpTableStatCountToKV execution: no slow query log after dumpTableStatCountToKV Mar 25, 2021
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 25, 2021
@jianzhiyao
Copy link
Contributor Author

/check_dev2

djshow832
djshow832 reviewed Mar 31, 2021
View reviewed changes
Copy link
Contributor

@djshow832 djshow832 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It won't prevent writing stats from locking each other. If two TiDB instances analyze tables at the same time, the conflicts still happen.

@jianzhiyao jianzhiyao closed this Mar 31, 2021
@jianzhiyao jianzhiyao changed the title execution: no slow query log after dumpTableStatCountToKV execution: no slow query log after dumpTableStatColSizeToKV Apr 1, 2021
@jianzhiyao jianzhiyao deleted the frt/internal_sql branch April 2, 2021 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djshow832 djshow832 djshow832 left review comments

@hanfei1991 hanfei1991 Awaiting requested review from hanfei1991

Assignees
No one assigned
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jianzhiyao @ti-chi-bot @djshow832