Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

store/tikv: move safepoint test to /tests #23637

Merged
merged 9 commits into from
Mar 30, 2021
Merged

store/tikv: move safepoint test to /tests #23637

merged 9 commits into from
Mar 30, 2021

Conversation

disksing
Copy link
Contributor

Signed-off-by: disksing i@disksing.com

What problem does this PR solve?

store/tikv has dependencies on mockstore and unistore because tests need to use them. We can resolve it by moving all tests to standaline package.

Part of #22513

What is changed and how it works?

What's Changed:

  • move test files into store/tikv/tests

Check List

Tests

  • Unit test

Release note

  • No release note

@disksing
store/tikv: move safepoint test to /tests
541c147 
Signed-off-by: disksing <i@disksing.com>
@disksing disksing added the sig/transaction SIG:Transaction label Mar 29, 2021
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 29, 2021
AndreMouche
AndreMouche reviewed Mar 30, 2021
View reviewed changes
store/tikv/tests/util_test.go
@@ -98,3 +100,17 @@ func (s *OneByOneSuite) TearDownSuite(c *C) {
withTiKVGlobalLock.RUnlock()
}
}

func encodeKey(prefix, s string) []byte {
Copy link
Contributor

@AndreMouche AndreMouche Mar 30, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicate function makes me unhappy to give LGTM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will remove one of them in the end.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 30, 2021
AndreMouche
AndreMouche approved these changes Mar 30, 2021
View reviewed changes
Copy link
Contributor

@AndreMouche AndreMouche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

@AndreMouche: Please use /LGTM instead of LGTM when you want to approve the pull request by comment.
If you use the GitHub review feature, please approve the PR directly, the comment will not take effect in the GitHub review feature.
If you have any qustions please refer to lgtm command help or lgtm plugin design.

If you have approved this PR, please ignore this reply. This reply is being used as a temporary reply during the migration of the new bot and will be removed on April 1.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AndreMouche
  • andylokandy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 30, 2021
@AndreMouche
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3f252b6

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 30, 2021
@AndreMouche
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@disksing: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit a8a52c0 into pingcap:master Mar 30, 2021
@disksing disksing deleted the t4 branch March 30, 2021 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andylokandy andylokandy andylokandy approved these changes

@AndreMouche AndreMouche AndreMouche approved these changes

Assignees
No one assigned
Labels
sig/transaction SIG:Transaction size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@disksing @ti-chi-bot @AndreMouche @andylokandy