Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: fix approx_percent panic on bit column #23687

Merged
merged 4 commits into from
Mar 30, 2021
Merged

expression: fix approx_percent panic on bit column #23687

merged 4 commits into from
Mar 30, 2021

Conversation

lzmhhh123
Copy link
Contributor

Signed-off-by: lzmhhh123 lzmhhh123@gmail.com

What problem does this PR solve?

Issue Number: close #23662

What is changed and how it works?

How it Works:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Release note

  • fix approx_percent panic on bit column

@lzmhhh123
expression: fix approx_percent panic on bit column
9c0b210 
Signed-off-by: lzmhhh123 <lzmhhh123@gmail.com>
@lzmhhh123 lzmhhh123 requested a review from a team as a code owner March 30, 2021 10:00
@lzmhhh123 lzmhhh123 requested review from qw4990 and removed request for a team March 30, 2021 10:00
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 30, 2021
@XuHuaiyu XuHuaiyu added needs-cherry-pick-4.0 needs-cherry-pick-release-5.0 sig/execution SIG execution type/bugfix This PR fixes a bug. priority/release-blocker This issue blocks a release. Please solve it ASAP. labels Mar 30, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 30, 2021
ichn-hu
ichn-hu requested changes Mar 30, 2021
View reviewed changes
Copy link
Contributor

@ichn-hu ichn-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests?

@ti-chi-bot ti-chi-bot removed the status/LGT1 Indicates that a PR has LGTM 1. label Mar 30, 2021
@lzmhhh123
add test
3e229d6 
Signed-off-by: lzmhhh123 <lzmhhh123@gmail.com>
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 30, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 30, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • ichn-hu
  • tangenta

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 30, 2021
@leiysky
Copy link
Contributor

leiysky commented Mar 30, 2021

/LGTM

@ti-chi-bot
Copy link
Member

@leiysky: /lgtm is only allowed for the reviewers in list.

In response to this:

/LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@lzmhhh123
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3e229d6

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 30, 2021
@ichn-hu ichn-hu mentioned this pull request Mar 30, 2021
Closed
@ti-chi-bot ti-chi-bot merged commit c32895f into pingcap:master Mar 30, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 30, 2021
@lzmhhh123 @ti-srebot
cherry pick pingcap#23687 to release-4.0
e720516 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 30, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #23702

@lzmhhh123 lzmhhh123 deleted the bug-fix/fix_approx_percent branch March 30, 2021 12:20
@ti-srebot ti-srebot mentioned this pull request Mar 30, 2021
Merged
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 30, 2021
@lzmhhh123 @ti-srebot
cherry pick pingcap#23687 to release-5.0
58e1e2a 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #23703

@ichn-hu ichn-hu mentioned this pull request Mar 31, 2021
Closed
ti-chi-bot pushed a commit that referenced this pull request May 6, 2021
@ti-srebot
expression: fix approx_percent panic on bit column (#23687) (#23702)
eb4113c
ti-chi-bot pushed a commit that referenced this pull request Aug 12, 2021
@ti-srebot
expression: fix approx_percent panic on bit column (#23687) (#23703)
0e8957e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ichn-hu ichn-hu ichn-hu approved these changes

@tangenta tangenta tangenta approved these changes

@qw4990 qw4990 Awaiting requested review from qw4990

Assignees
No one assigned
Labels
component/expression needs-cherry-pick-release-5.0 priority/release-blocker This issue blocks a release. Please solve it ASAP. sig/execution SIG execution size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tidb panic in the recoverable goroutine
7 participants
@lzmhhh123 @ti-chi-bot @leiysky @ti-srebot @tangenta @ichn-hu @XuHuaiyu