Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util: fix range building for binary literal #23699

Merged
merged 3 commits into from
Mar 31, 2021
Merged

util: fix range building for binary literal #23699

merged 3 commits into from
Mar 31, 2021

Conversation

wjhuang2016
Copy link
Member

Signed-off-by: wjhuang2016 huangwenjun1997@gmail.com

What problem does this PR solve?

Issue Number: close #23672

Problem Summary:
We take binary literal as string, so we should set collation for them when builds the range.

What is changed and how it works?

If the type of the datum is binary literal, set it collation.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Side effects

Release note

  • fix range building for binary literal

@wjhuang2016
done
2dcfddc 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@wjhuang2016 wjhuang2016 requested review from a team as code owners March 30, 2021 11:36
@wjhuang2016 wjhuang2016 requested review from qw4990 and lzmhhh123 and removed request for a team March 30, 2021 11:36
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 30, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 30, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qw4990
  • winoros

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 30, 2021
@qw4990
Copy link
Contributor

qw4990 commented Mar 30, 2021

/run-all-tests

@Reminiscent
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@Reminiscent: /merge is only allowed for the committers in list.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@wjhuang2016
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

@wjhuang2016: /merge is only allowed for the committers in list.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@wjhuang2016 wjhuang2016 removed the sig/planner SIG: Planner label Mar 31, 2021
@wjhuang2016
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 0a6dc0b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 31, 2021
@ti-chi-bot ti-chi-bot merged commit 8fca6a2 into pingcap:master Mar 31, 2021
@wjhuang2016
Copy link
Member Author

/run-cherry-picker

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 15, 2021
@wjhuang2016 @ti-srebot
cherry pick pingcap#23699 to release-5.0
a62e2e3 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 15, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #24041

ti-chi-bot pushed a commit that referenced this pull request Apr 16, 2021
@ti-srebot
util: fix range building for binary literal (#23699) (#24041)
7f3fbe3
@xuyifangreeneyes xuyifangreeneyes mentioned this pull request Jul 22, 2021
Closed
@xuyifangreeneyes
Copy link
Contributor

@wjhuang2016 #26439 says that release-4.0 has a similar bug that can be fixed by this PR, shall we cherry pick the PR to 4.0?

@wjhuang2016
Copy link
Member Author

/run-cherry-picker

@ti-srebot ti-srebot mentioned this pull request Jul 22, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #26455

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 22, 2021
@wjhuang2016 @ti-srebot
cherry pick pingcap#23699 to release-4.0
cc00bf5 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
ti-chi-bot pushed a commit that referenced this pull request Sep 10, 2021
@ti-srebot
util: fix range building for binary literal (#23699) (#26455)
2b52022
@qw4990 qw4990 mentioned this pull request Jan 4, 2022
Merged
12 tasks
@ti-srebot ti-srebot mentioned this pull request Jan 5, 2022
Merged
12 tasks
@wjhuang2016 wjhuang2016 deleted the fix_binary_literal branch November 17, 2022 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros approved these changes

@qw4990 qw4990 qw4990 approved these changes

@lzmhhh123 lzmhhh123 Awaiting requested review from lzmhhh123

Assignees
No one assigned
Labels
component/expression needs-cherry-pick-release-5.0 size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use hexadecimal to select and get wrong results when opening new collation
7 participants
@wjhuang2016 @ti-chi-bot @qw4990 @Reminiscent @ti-srebot @xuyifangreeneyes @winoros