-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: fix wrong TableDual plans caused by comparing Binary and Bytes incorrectly (#23860) #23918
planner: fix wrong TableDual plans caused by comparing Binary and Bytes incorrectly (#23860) #23918
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
/run-all-tests |
@qw4990 you're already a collaborator in bot's repo. |
planner/core/integration_test.go
Outdated
@@ -3051,3 +3051,35 @@ func (s *testIntegrationSuite) TestIssue23736(c *C) { | |||
// Should not use invisible index | |||
c.Assert(tk.MustUseIndex("select /*+ stream_agg() */ count(1) from t0 where c > 10 and b < 2", "c"), IsFalse) | |||
} | |||
<<<<<<< HEAD | |||
======= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@qw4990 please resolve conflicts.
/lgtm |
PTAL @time-and-fate @rebelice |
/run-all-tests |
1 similar comment
/run-all-tests |
Seems we need to wait #24041 merged to get this PR pass |
@qw4990
|
/run-all-tests |
/merge |
@zimulala: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
@ti-srebot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
cherry-pick #23860 to release-5.0
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/23918
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #23846
Problem Summary: planner: fix wrong TableDual plans caused by comparing Binary and Bytes incorrectly
What is changed and how it works?
planner: fix wrong TableDual plans caused by comparing Binary and Bytes incorrectly
Check List
Tests
Release note