Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: refactor bundle[1/2] [5/6] #24008

Merged
merged 5 commits into from
Jun 11, 2021
Merged

ddl: refactor bundle[1/2] [5/6] #24008

merged 5 commits into from
Jun 11, 2021

Conversation

xhebox
Copy link
Contributor

@xhebox xhebox commented Apr 14, 2021 •
edited
Loading

What problem does this PR solve?

Problem Summary: Separate from #22415, 5/6 patch from the large PR.

  1. BuildPlacementDropBundle is replaced by NewBundle. Since dropping is notifying PD an empty bundle.
  2. BuildPlacementCopyBundle is replaced by bundle.Clone().Reset(id).
  3. AlterTableAlterPartition now relies on ApplyPlacementSpec, Tidy, Reset to perform the building.
  4. Move all Bundle things to bundle.go, and a full cover test in bundle_test.go.

Check List

Tests

  • Unit test
  • Integration test

Release note

  • No release note

@xhebox xhebox requested a review from a team as a code owner April 14, 2021 06:19
@xhebox xhebox requested review from lzmhhh123 and removed request for a team April 14, 2021 06:19
@ti-chi-bot ti-chi-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 14, 2021
@xhebox xhebox requested review from a team and removed request for lzmhhh123 April 14, 2021 07:27
@xhebox xhebox force-pushed the master_5 branch 3 times, most recently from b1a9377 to d7986da Compare April 17, 2021 04:19
@xhebox xhebox force-pushed the master_5 branch 2 times, most recently from 73ebb21 to 88b8350 Compare April 22, 2021 07:44
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 15, 2021
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 15, 2021
@djshow832
Copy link
Contributor

/lgtm

@ti-chi-bot ti-chi-bot added status/LGT1 Indicates that a PR has LGTM 1. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 15, 2021
@xhebox
ddl: refactor bundle[1/2]
79fb48c 
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox
ddl: better comment
3354e2e 
Signed-off-by: xhe <xw897002528@gmail.com>
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 18, 2021
@morgo
Copy link
Contributor

morgo commented Jun 11, 2021

/LGTM

@ti-chi-bot
Copy link
Member

@morgo: Please use GitHub review feature instead of /lgtm [cancel] when you want to submit review to the pull request.
For how to use GitHub review feature, see also this document provided by GitHub.

For the reason we drop support to the commands, see also this page.
This reply is being used as a temporary reply during the migration of review process and will be removed on July 1st.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • djshow832
  • morgo

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot removed the status/LGT1 Indicates that a PR has LGTM 1. label Jun 11, 2021
@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Jun 11, 2021
@xhebox
Copy link
Contributor Author

xhebox commented Jun 11, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ad68f2c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 11, 2021
@ti-chi-bot
Copy link
Member

@xhebox: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@xhebox
Copy link
Contributor Author

xhebox commented Jun 11, 2021

/run-common-test

@ti-chi-bot ti-chi-bot merged commit 10db453 into pingcap:master Jun 11, 2021
@xhebox xhebox mentioned this pull request Jul 7, 2021
Closed
@xhebox xhebox deleted the master_5 branch September 28, 2021 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morgo morgo morgo approved these changes

Assignees
No one assigned
Labels
component/expression sig/execution SIG execution sig/sql-infra SIG: SQL Infra size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xhebox @djshow832 @morgo @ti-chi-bot