Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidb-server: handle the help manually #24073

Merged
merged 2 commits into from
Apr 16, 2021
Merged

Conversation

xhebox
Copy link
Contributor

@xhebox xhebox commented Apr 16, 2021

What problem does this PR solve?

Issue Number: close #24046

Problem Summary: Check flag: exit 0 when -h or -help invoked but undefined. The newer go does not have this problem. But we can still solve it by manually triggering the usage.

Check List

Tests

  • Unit test
  • Integration test

Release note

  • Set the return value to 0 if --help is passed to cli, for golang below version 1.15

Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox xhebox requested a review from a team April 16, 2021 04:13
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 16, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 16, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • wjhuang2016
  • xiongjiwei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 16, 2021
@xhebox
Copy link
Contributor Author

xhebox commented Apr 16, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ba64035

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 16, 2021
@xhebox
Copy link
Contributor Author

xhebox commented Apr 16, 2021

/run-e2e-test

@ti-chi-bot ti-chi-bot merged commit cd25915 into pingcap:master Apr 16, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 16, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #24074

@xhebox xhebox deleted the server_2 branch April 20, 2021 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-5.0 sig/sql-infra SIG: SQL Infra size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tidb-server --help exit with code 2
5 participants