Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs/design: add proposal for common table expression #24147

Merged
merged 18 commits into from
Jun 16, 2021
Merged

docs/design: add proposal for common table expression #24147

merged 18 commits into from
Jun 16, 2021

Conversation

guo-shaoge
Copy link
Collaborator

@guo-shaoge guo-shaoge commented Apr 20, 2021 •
edited by wjhuang2016
Loading

What problem does this PR solve?

Issue Number: close #24107

Problem Summary: add design doc for CTE.

What is changed and how it works?

How it Works: check overview of the doc.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

None

Release note

  • docs/design: add proposal for common table expression

@guo-shaoge guo-shaoge requested review from a team as code owners April 20, 2021 03:11
@guo-shaoge guo-shaoge requested review from wshwsh12 and eurekaka and removed request for a team April 20, 2021 03:11
@ti-chi-bot ti-chi-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 20, 2021
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 20, 2021
@guo-shaoge
Copy link
Collaborator Author

@wjhuang2016 PTAL

wjhuang2016
wjhuang2016 reviewed Apr 20, 2021
View reviewed changes
docs/design/2021-04-18-common-table-expression.md Outdated Show resolved Hide resolved
docs/design/2021-04-18-common-table-expression.md Outdated Show resolved Hide resolved
docs/design/2021-04-18-common-table-expression.md Outdated Show resolved Hide resolved
docs/design/2021-04-18-common-table-expression.md Show resolved Hide resolved
docs/design/2021-04-18-common-table-expression.md Outdated Show resolved Hide resolved
docs/design/2021-04-18-common-table-expression.md Outdated Show resolved Hide resolved
@tisonkun
Copy link
Contributor

ref #17472

@guo-shaoge
Copy link
Collaborator Author

/run-check_dev_2

@wjhuang2016
Copy link
Member

/lgtm , it needs to modify after we implementing it, but it's ok to get merged now.

@wjhuang2016
Copy link
Member

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 21, 2021
@guo-shaoge guo-shaoge mentioned this pull request Apr 21, 2021
Merged
@tisonkun tisonkun mentioned this pull request Apr 22, 2021
Closed
pingyu
pingyu reviewed Apr 23, 2021
View reviewed changes
docs/design/2021-04-18-common-table-expression.md Outdated Show resolved Hide resolved
docs/design/2021-04-18-common-table-expression.md Outdated Show resolved Hide resolved
docs/design/2021-04-18-common-table-expression.md Outdated Show resolved Hide resolved
docs/design/2021-04-18-common-table-expression.md Outdated Show resolved Hide resolved
docs/design/2021-04-18-common-table-expression.md Outdated Show resolved Hide resolved
docs/design/2021-04-18-common-table-expression.md Outdated Show resolved Hide resolved
docs/design/2021-04-18-common-table-expression.md Outdated Show resolved Hide resolved
docs/design/2021-04-18-common-table-expression.md Outdated Show resolved Hide resolved
docs/design/2021-04-18-common-table-expression.md Outdated Show resolved Hide resolved
docs/design/2021-04-18-common-table-expression.md Outdated Show resolved Hide resolved
@tisonkun tisonkun mentioned this pull request May 13, 2021
Closed
@tisonkun
Copy link
Contributor

@pingyu could you review this design document again these days?

@tisonkun
Copy link
Contributor

/cc @xiongjiwei

@wjhuang2016
Copy link
Member

This document is out of date. We plan to update it in a few weeks. If you want to know the current design, you can talk with us.

@wjhuang2016 wjhuang2016 mentioned this pull request May 20, 2021
Merged
@guo-shaoge guo-shaoge mentioned this pull request May 21, 2021
Merged
@guo-shaoge
trivial change
1638197 
Signed-off-by: guo-shaoge <shaoge1994@163.com>
@guo-shaoge
modify according to comments
dc86a39 
Signed-off-by: guo-shaoge <shaoge1994@163.com>
@guo-shaoge
trivial change
7d83c07 
Signed-off-by: guo-shaoge <shaoge1994@163.com>
@guo-shaoge
trivial change
7034052 
Signed-off-by: guo-shaoge <shaoge1994@163.com>
@guo-shaoge
TempTable -> CTETable
f676c1f 
Signed-off-by: guo-shaoge <shaoge1994@163.com>
@guo-shaoge
fix typos
31f5965 
Signed-off-by: guo-shaoge <shaoge1994@163.com>
@guo-shaoge
fix spelling
89dd039 
Signed-off-by: guo-shaoge <shaoge1994@163.com>
@guo-shaoge
update doc
5b85af1 
Signed-off-by: guo-shaoge <shaoge1994@163.com>
@guo-shaoge
update imgs
5a12b5b 
Signed-off-by: guo-shaoge <shaoge1994@163.com>
@guo-shaoge
update img
f758e6a 
Signed-off-by: guo-shaoge <shaoge1994@163.com>
@guo-shaoge
update
5b8758f 
Signed-off-by: guo-shaoge <shaoge1994@163.com>
@guo-shaoge
update
c0903d5 
Signed-off-by: guo-shaoge <shaoge1994@163.com>
@guo-shaoge
update
23cf4bc 
Signed-off-by: guo-shaoge <shaoge1994@163.com>
tisonkun
tisonkun reviewed Jun 11, 2021
View reviewed changes
Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates. Minor comments inline.

docs/design/2021-04-18-common-table-expression.md Outdated Show resolved Hide resolved
docs/design/2021-04-18-common-table-expression.md Outdated Show resolved Hide resolved
@guo-shaoge
fmt
5b12846 
Signed-off-by: guo-shaoge <shaoge1994@163.com>
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • wjhuang2016
  • xiongjiwei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 12, 2021
@guo-shaoge
fix comment
4183bb3 
Signed-off-by: guo-shaoge <shaoge1994@163.com>
@guo-shaoge
Copy link
Collaborator Author

@wjhuang2016 PTAL

@wjhuang2016
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 4183bb3

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 16, 2021
@ti-chi-bot
Copy link
Member

@guo-shaoge: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 9461f5b into pingcap:master Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tisonkun tisonkun tisonkun left review comments

@pingyu pingyu pingyu left review comments

@xiongjiwei xiongjiwei xiongjiwei approved these changes

@wjhuang2016 wjhuang2016 wjhuang2016 approved these changes

@eurekaka eurekaka Awaiting requested review from eurekaka

Assignees
No one assigned
Labels
size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add design document for common table expression
6 participants
@guo-shaoge @tisonkun @wjhuang2016 @ti-chi-bot @pingyu @xiongjiwei