Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor, variable: move hidden variables to struct #24304

Merged
merged 2 commits into from
Apr 28, 2021
Merged

executor, variable: move hidden variables to struct #24304

merged 2 commits into from
Apr 28, 2021

Conversation

morgo
Copy link
Contributor

@morgo morgo commented Apr 26, 2021

What problem does this PR solve?

Problem Summary:

This moves the hidden attribute of a feature switch to the sysvar struct. This makes it possible for plugins to also create hidden variables, which may be a nice property in the future.

I also think it is useful for noop sysvars; since for many of them if they are hidden they will pass compatibility requirements, but not confuse users. I saw a user on TiDB slack today asking about setting innodb_log_file_size, which is a problem of our creation.

What is changed and how it works?

What's Changed:

Internal refactor, function neutral.

Related changes

Check List

Tests

  • Unit test (existing)

Side effects

  • None

Release note

  • No release note

@morgo morgo requested a review from a team as a code owner April 26, 2021 22:31
@morgo morgo requested review from lzmhhh123 and removed request for a team April 26, 2021 22:31
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 26, 2021
@github-actions github-actions bot added the sig/execution SIG execution label Apr 26, 2021
ichn-hu
ichn-hu approved these changes Apr 27, 2021
View reviewed changes
Copy link
Contributor

@ichn-hu ichn-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 27, 2021
@ti-chi-bot
Copy link
Member

@xhebox: /lgtm is only allowed for the reviewers in list.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@xhebox: /merge is only allowed for the committers in list.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@morgo morgo added the sig/sql-infra SIG: SQL Infra label Apr 28, 2021
@morgo
Copy link
Contributor Author

morgo commented Apr 28, 2021

@xhebox I've added sig-sql-infra if you want to try approving again.

xhebox
xhebox approved these changes Apr 28, 2021
View reviewed changes
Copy link
Contributor

@xhebox xhebox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. IIRC, the filter is introduced by our SIG anyway...

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • ichn-hu
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 28, 2021
@xhebox
Copy link
Contributor

xhebox commented Apr 28, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 939a89f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 28, 2021
@ti-chi-bot ti-chi-bot merged commit 22dbcc5 into pingcap:master Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ichn-hu ichn-hu ichn-hu approved these changes

@xhebox xhebox xhebox approved these changes

@lzmhhh123 lzmhhh123 Awaiting requested review from lzmhhh123

Assignees
No one assigned
Labels
sig/execution SIG execution sig/sql-infra SIG: SQL Infra size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@morgo @ti-chi-bot @xhebox @ichn-hu