Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: add partition compatibility for temporary table #24406

Merged
merged 33 commits into from
May 6, 2021
Merged

ddl: add partition compatibility for temporary table #24406

merged 33 commits into from
May 6, 2021

Conversation

Howie59
Copy link
Contributor

@Howie59 Howie59 commented May 2, 2021

What problem does this PR solve?

Issue Number: see #24168

What is changed and how it works?

Proposal: temporary table

What's Changed: add partition compatibility for temporary table

Check List

Tests

  • Unit test

Release note

  • No release note

@Howie59
Merge pull request #1 from pingcap/master
e0469fc 
merge master
@Howie59
Merge branch 'master' of https://github.saobby.my.eu.org.cnpmjs.org/pingcap/tidb
7d60de6
@Howie59
Merge branch 'master' of https://github.saobby.my.eu.org.cnpmjs.org/Pingcap/tidb
0297c4a
@Howie59
Merge branch 'master' of https://github.saobby.my.eu.org.cnpmjs.org/Pingcap/tidb
d4aa60c
@Howie59
Merge branch 'master' of https://github.saobby.my.eu.org.cnpmjs.org/pingcap/tidb
0362a4b
@Howie59
Merge branch 'master' of https://github.com/pingcap/tidb
382f2ce
@Howie59
Merge branch 'master' of https://github.saobby.my.eu.org.cnpmjs.org/pingcap/tidb
1108209
@Howie59
Merge branch 'master' of https://github.saobby.my.eu.org.cnpmjs.org/pingcap/tidb
bf43b07
@Howie59
Merge branch 'master' of https://github.saobby.my.eu.org.cnpmjs.org/pingcap/tidb
9e41542
@Howie59
Merge branch 'master' of https://github.saobby.my.eu.org.cnpmjs.org/pingcap/tidb
dfc62d3
@Howie59
Merge branch 'master' of https://github.saobby.my.eu.org.cnpmjs.org/pingcap/tidb
27572fa
@Howie59
Merge branch 'master' of https://github.saobby.my.eu.org.cnpmjs.org/pingcap/tidb
b74d2d5
@Howie59
Merge branch 'master' of https://github.saobby.my.eu.org.cnpmjs.org/pingcap/tidb
9f13862
@Howie59
Merge branch 'master' of https://github.saobby.my.eu.org.cnpmjs.org/pingcap/tidb
6a86dcd
@Howie59
raise err when partition in temporary mode
cd9321c
@Howie59
change pos
765208a
@Howie59
Merge branch 'master' of https://github.saobby.my.eu.org.cnpmjs.org/pingcap/tidb i…
bb4b31a 
…nto check-partition
@Howie59
add tests
1c2aedd
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 2, 2021
@github-actions github-actions bot added the sig/sql-infra SIG: SQL Infra label May 2, 2021
@Howie59
Copy link
Contributor Author

Howie59 commented May 2, 2021

/run-all-tests

@purelind
Copy link
Contributor

purelind commented May 2, 2021

/run-all-tests

@purelind
Copy link
Contributor

purelind commented May 2, 2021

/run-check_dev

@purelind
Copy link
Contributor

purelind commented May 2, 2021

/run-mybatis-test

@purelind
Copy link
Contributor

purelind commented May 2, 2021

/run-all-tests

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 6, 2021
djshow832
djshow832 reviewed May 6, 2021
View reviewed changes
ddl/db_partition_test.go Outdated Show resolved Hide resolved
@djshow832
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • djshow832
  • morgo

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 6, 2021
@djshow832
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6892896

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 6, 2021
@djshow832
Copy link
Contributor

/merge

@sonarcloud
Copy link

sonarcloud bot commented May 6, 2021

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
16.8% 16.8% Duplication

@ti-chi-bot
Copy link
Member

@Howie59: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sre-bot
Copy link
Contributor

sre-bot commented May 6, 2021

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what's changed

Or if the count of mainly changed packages are more than 3, use

  • *: what's changed

@Howie59
Copy link
Contributor Author

Howie59 commented May 6, 2021

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit bc4a38c into pingcap:master May 6, 2021
@djshow832 djshow832 mentioned this pull request May 6, 2021
Closed
89 tasks
@Howie59 Howie59 deleted the check-partition branch May 11, 2021 14:24
@Howie59 Howie59 mentioned this pull request May 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djshow832 djshow832 djshow832 left review comments

@morgo morgo Awaiting requested review from morgo

Assignees
No one assigned
Labels
sig/sql-infra SIG: SQL Infra size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Howie59 @purelind @morgo @djshow832 @ti-chi-bot @sre-bot