inforschema, executor, util/kvcache, util/statement_summary : Add STATEMENTS_SUMMARY_EVICTED into information_schema #24513
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,164 @@ | ||
| package stmtsummary | ||
djshow832 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| import ( | ||
| "container/list" | ||
| "time" | ||
|
|
||
| "github.com/pingcap/parser/mysql" | ||
| "github.com/pingcap/tidb/types" | ||
| ) | ||
|
|
||
| // stmtSummaryByDigestEvicted contents digests evicted from stmtSummaryByDigestMap | ||
| type stmtSummaryByDigestEvicted struct { | ||
| // record evicted data in intervals | ||
| // latest history data is Back() | ||
| history *list.List | ||
| } | ||
|
|
||
| // element being stored in stmtSummaryByDigestEvicted | ||
| type stmtSummaryByDigestEvictedElement struct { | ||
| // beginTime is the begin time of current interval | ||
| beginTime int64 | ||
| // endTime is the end time of current interval | ||
| endTime int64 | ||
| // *Kinds* of digest being evicted | ||
| digestKeyMap map[string]struct{} | ||
| } | ||
|
|
||
| // spawn a new pointer to stmtSummaryByDigestEvicted | ||
| func newStmtSummaryByDigestEvicted() *stmtSummaryByDigestEvicted { | ||
| return &stmtSummaryByDigestEvicted{ | ||
| history: list.New(), | ||
| } | ||
| } | ||
|
|
||
| // spawn a new pointer to stmtSummaryByDigestEvictedElement | ||
| func newStmtSummaryByDigestEvictedElement(beginTime int64, endTime int64) *stmtSummaryByDigestEvictedElement { | ||
| return &stmtSummaryByDigestEvictedElement{ | ||
| beginTime: beginTime, | ||
| endTime: endTime, | ||
| digestKeyMap: make(map[string]struct{}), | ||
| } | ||
| } | ||
|
|
||
| // AddEvicted is used add an evicted record to stmtSummaryByDigestEvicted | ||
| func (ssbde *stmtSummaryByDigestEvicted) AddEvicted(evictedKey *stmtSummaryByDigestKey, evictedValue *stmtSummaryByDigest, historySize int) { | ||
crazycs520 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| evictedValue.Lock() | ||
| defer evictedValue.Unlock() | ||
| if evictedValue == nil { | ||
| return | ||
| } | ||
|
|
||
| for e, h := evictedValue.history.Back(), ssbde.history.Back(); e != nil; e = e.Prev() { | ||
| evictedElement := e.Value.(*stmtSummaryByDigestElement) | ||
| eBeginTime := evictedElement.beginTime | ||
| eEndTime := evictedElement.endTime | ||
|
|
||
| // no record in ssbde.history, direct insert | ||
| if ssbde.history.Len() == 0 { | ||
| record := newStmtSummaryByDigestEvictedElement(eBeginTime, eEndTime) | ||
| record.addEvicted(evictedKey, evictedElement) | ||
| ssbde.history.PushFront(record) | ||
| continue | ||
| } | ||
|
|
||
| // prevent exceeding history size | ||
| for ssbde.history.Len() >= historySize && ssbde.history.Len() > 1 { | ||
| ssbde.history.Remove(ssbde.history.Front()) | ||
| } | ||
|
|
||
| // look for matching history interval | ||
| // if there are no records in ssbde.history, following code will not be executed. Such situation will probably lead to a bug. | ||
|
There was a problem hiding this comment. The comment situation seems never to happen? since line71 already handle this case, can we remove this comment now? It looks scary |
||
| MATCHING: | ||
| for ; h != nil; h = h.Prev() { | ||
| historyElement := h.Value.(*stmtSummaryByDigestEvictedElement) | ||
|
|
||
| switch historyElement.matchAndAdd(evictedKey, evictedElement) { | ||
| case isMatch: | ||
| // automatically added | ||
| break MATCHING | ||
| // not matching, create a new record and insert | ||
| case isTooYoung: | ||
| { | ||
| record := newStmtSummaryByDigestEvictedElement(eBeginTime, eEndTime) | ||
| record.addEvicted(evictedKey, evictedElement) | ||
| ssbde.history.InsertAfter(record, h) | ||
| break MATCHING | ||
| } | ||
| default: // isTooOld | ||
| { | ||
| if h == ssbde.history.Front() { | ||
| // if digest older than all records in ssbde.history. | ||
| record := newStmtSummaryByDigestEvictedElement(eBeginTime, eEndTime) | ||
| record.addEvicted(evictedKey, evictedElement) | ||
| ssbde.history.PushFront(record) | ||
| break MATCHING | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| // Clear up all records in stmtSummaryByDigestEvicted | ||
| func (ssbde *stmtSummaryByDigestEvicted) Clear() { | ||
| ssbde.history.Init() | ||
| } | ||
|
|
||
| // add an evicted record to stmtSummaryByDigestEvictedElement | ||
| func (seElement *stmtSummaryByDigestEvictedElement) addEvicted(digestKey *stmtSummaryByDigestKey, digestValue *stmtSummaryByDigestElement) { | ||
| if digestKey != nil { | ||
| seElement.digestKeyMap[string(digestKey.Hash())] = struct{}{} | ||
| } | ||
| } | ||
|
|
||
| const ( | ||
| isMatch = 0 | ||
| isTooOld = 1 | ||
| isTooYoung = 2 | ||
| ) | ||
|
|
||
| // matchAndAdd check time interval of seElement and digestValue. | ||
| // if matches, it will add the digest and return enum match | ||
| // if digest too old, it will return enum tooOld and do nothing | ||
| // if digest too young, it will return enum tooYoung and do nothing | ||
| func (seElement *stmtSummaryByDigestEvictedElement) matchAndAdd(digestKey *stmtSummaryByDigestKey, digestValue *stmtSummaryByDigestElement) (statement int) { | ||
| if seElement == nil || digestValue == nil { | ||
| return isTooYoung | ||
| } | ||
| sBeginTime, sEndTime := seElement.beginTime, seElement.endTime | ||
| eBeginTime, eEndTime := digestValue.beginTime, digestValue.endTime | ||
| if sBeginTime <= eBeginTime && eEndTime <= sEndTime { | ||
| seElement.addEvicted(digestKey, digestValue) | ||
| return isMatch | ||
| } else if eEndTime <= sBeginTime { | ||
| return isTooOld | ||
| } else { | ||
| return isTooYoung | ||
| } | ||
| } | ||
|
|
||
| // ToEvictedCountDatum converts history evicted record to `evicted count` record's datum | ||
| func (ssbde *stmtSummaryByDigestEvicted) ToEvictedCountDatum() [][]types.Datum { | ||
| records := make([][]types.Datum, 0, ssbde.history.Len()) | ||
| for e := ssbde.history.Front(); e != nil; e = e.Next() { | ||
| if record := e.Value.(*stmtSummaryByDigestEvictedElement).toEvictedCountDatum(); record != nil { | ||
| records = append(records, record) | ||
| } | ||
| } | ||
| return records | ||
| } | ||
|
|
||
| // toEvictedCountDatum converts evicted record to `EvictedCount` record's datum | ||
| func (seElement *stmtSummaryByDigestEvictedElement) toEvictedCountDatum() []types.Datum { | ||
| datum := types.MakeDatums( | ||
| types.NewTime(types.FromGoTime(time.Unix(seElement.beginTime, 0)), mysql.TypeTimestamp, 0), | ||
| types.NewTime(types.FromGoTime(time.Unix(seElement.endTime, 0)), mysql.TypeTimestamp, 0), | ||
| int64(len(seElement.digestKeyMap)), | ||
| ) | ||
| return datum | ||
| } | ||
|
|
||
| func (ssMap *stmtSummaryByDigestMap) ToEvictedCountDatum() [][]types.Datum { | ||
| return ssMap.other.ToEvictedCountDatum() | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this line
returnis unnecessary😏There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A former python user began coding in go, this is what happend to his typo.