privilege: fix RequestVerificationWithUser use of default roles (#24442)

[ti-srebot]

cherry-pick #24442 to release-5.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/24532

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/24532:release-5.0-b8cad01bef30

---

What problem does this PR solve?

Issue Number: close #24414

Problem Summary:

Views support a feature to run in the security of the DEFINER. This is useful because it allows column level / row level security to effectively be supported, when TiDB supports neither.

However, the implementation was buggy because RequestVerificationWithUser in the privilege API did not consider default roles for that user correctly. In this fix it now does.

What is changed and how it works?

What's Changed:

Bug fix only.

Related changes

• Need to cherry-pick to the release branch

Check List

Tests

• Integration test

Side effects

• None

Release note

• SQL Views now consider the default roles associated with the SQL DEFINER correctrly.

[ti-srebot]

/run-all-tests

[ti-srebot]

@morgo please accept the invitation then you can push to the cherry-pick pull requests.
https://github.com/ti-srebot/tidb/invitations

[bb7133]

/lgtm

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• bb7133
• wjhuang2016

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

[bb7133]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 477f76c

[morgo]

/run-all-tests

[morgo]

/run-unit-test

[morgo]

/merge

[morgo]

@zhouqiang-cl This was cherry picked to 4.0 but not 5.0. This is a problem because the user who reported the issue was on 4.0 but they've now upgraded to 5.0. So the bug is not fixed for them :(

[ti-chi-bot]

@ti-srebot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.