-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
store/copr: balance region for batch cop task (#24521) #24724
store/copr: balance region for batch cop task (#24521) #24724
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot: This cherry pick PR is for a release branch and has not yet been approved by release team. To merge this cherry pick, it must first be approved ( AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/run-all-tests |
@windtalker you're already a collaborator in bot's repo. |
/run-all-tests |
/run-unit-test |
/LGTM |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
store/tikv/region_cache.go
Outdated
func (c *RegionCache) OnSendFailForBatchRegions(bo *Backoffer, store *Store, regionInfos []RegionInfo, scheduleReload bool, err error) { | ||
metrics.RegionCacheCounterWithSendFail.Add(float64(len(regionInfos))) | ||
if store.storeType != TiFlash { | ||
logutil.Logger(bo.GetCtx()).Info("Should not reach here, OnSendFailForBatchRegions only support TiFlash") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The level should be warn
or error
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 9ebdbbb
|
/run-common-test |
cherry-pick #24521 to release-5.0
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/24724
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close pingcap/tiflash#1854
Problem Summary:
For mpp queries, if a table has more than 1 replicas, the table scan task of this table does not balance the scan region between the TiFlash nodes, so it is possible that although the regions are evenly distributed on several TiFlash nodes, the
scanned regions on each TiFlash nodes for a specific mpp query is very uneven
What is changed and how it works?
Proposal: xxx
What's Changed:
How it Works:
In
buildBatchCopTasks
, when all the regions to be read is collected, it will callbalanceBatchCopTask
to balance region for batch cop task.Related changes
pingcap/docs
/pingcap/docs-cn
:Check List
Tests
By add some extra log in TiDB, the balance result looks like this:
Side effects
Release note