-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: add a test case for 'tidb_constraint_check_in_place' on temporary table #24784
executor: add a test case for 'tidb_constraint_check_in_place' on temporary table #24784
Conversation
/run-check_dev_2 |
/run-check_dev_2 |
/lgtm |
@djshow832: Thanks for your review. The bot only counts In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/lgtm |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: b251392
|
/run-all-tests This bot automatically retries jobs that failed on can merge PRs (send feedback to hi-rustin). Silence the bot with the |
2 similar comments
/run-all-tests This bot automatically retries jobs that failed on can merge PRs (send feedback to hi-rustin). Silence the bot with the |
/run-all-tests This bot automatically retries jobs that failed on can merge PRs (send feedback to hi-rustin). Silence the bot with the |
/run-all-tests This bot automatically retries jobs that failed on can merge PRs (send feedback to hi-rustin). Silence the bot with the |
1 similar comment
/run-all-tests This bot automatically retries jobs that failed on can merge PRs (send feedback to hi-rustin). Silence the bot with the |
@tiancaiamao: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/run-all-tests This bot automatically retries jobs that failed on can merge PRs (send feedback to hi-rustin). Silence the bot with the |
What problem does this PR solve?
Problem Summary:
tidb_constraint_check_in_place
is a variable that controls the index uniqueness check.If this variable is set to false, we will delay the check to 2PC commit. We presume the index key doesn't exist, adding those key to 2PC mutations and ask TiKV to verify that.
For the temporary table, we do not actually write to TiKV.
So I worried this variable would conflict with the temporary table feature.
It turned out that I'm wrong... the current code works well.
Anyway, I'd like to add a test to cover that.
What is changed and how it works?
What's Changed:
Add a test case
How it Works:
Check List
Tests
Release note