Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: enforce push mpp down #24849

Merged
merged 5 commits into from
May 23, 2021
Merged

planner: enforce push mpp down #24849

merged 5 commits into from
May 23, 2021

Conversation

LittleFall
Copy link
Contributor

@LittleFall LittleFall commented May 23, 2021 •
edited
Loading

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:

How it Works:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note

  • No release note

@LittleFall LittleFall requested review from a team as code owners May 23, 2021 16:00
@LittleFall LittleFall requested review from wshwsh12 and winoros and removed request for a team May 23, 2021 16:00
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 23, 2021
@github-actions github-actions bot added the sig/execution SIG execution label May 23, 2021
windtalker
windtalker reviewed May 23, 2021
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix build

@LittleFall
Copy link
Contributor Author

/run-all-tests

@LittleFall
Copy link
Contributor Author

/run-sqllogic-test-1

1 similar comment
@LittleFall
Copy link
Contributor Author

/run-sqllogic-test-1

@LittleFall
Copy link
Contributor Author

/run-all-tests

@LittleFall
Copy link
Contributor Author

/run-sqllogic-test-1

zanmato1984
zanmato1984 approved these changes May 23, 2021
View reviewed changes
Copy link
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

@zanmato1984: Thanks for your review. The bot only counts /lgtm from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@zanmato1984 zanmato1984 merged commit 7204906 into pingcap:hanfei/release5.0-hotfix-tiflash-patch May 23, 2021
@LittleFall LittleFall deleted the enforce branch May 25, 2021 07:23
LittleFall added a commit to LittleFall/tidb that referenced this pull request Jul 20, 2021
@LittleFall
planner: enforce push mpp down (pingcap#24849)
bcf9061
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@windtalker windtalker windtalker left review comments

@zanmato1984 zanmato1984 zanmato1984 approved these changes

@wshwsh12 wshwsh12 Awaiting requested review from wshwsh12

@winoros winoros Awaiting requested review from winoros

Assignees
No one assigned
Labels
sig/execution SIG execution size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LittleFall @ti-chi-bot @zanmato1984 @windtalker