ddl: add admin_checksum_table compatibility for temporary table #24867
Conversation
ti-chi-bot
added
the
size/S
…nto admin_checksum_table
ti-chi-bot
added
size/M
executor/admin_test.go
Outdated
| fmt.Println(core.ErrOptOnTemporaryTable.GenWithStackByArgs("admin checksum table")) | ||
| fmt.Println(err.Error()) |
There was a problem hiding this comment.
Remove debug log please ...
planner/core/preprocess.go
Outdated
| if stmt.Tp == ast.AdminChecksumTable { | ||
| p.err = ErrOptOnTemporaryTable.GenWithStackByArgs("admin checksum table") | ||
| } else { | ||
| p.err = infoschema.ErrAdminCheckTable |
There was a problem hiding this comment.
| p.err = infoschema.ErrAdminCheckTable | |
| p.err = ErrOptOnTemporaryTable.GenWithStackByArgs("admin table") |
There was a problem hiding this comment.
ErrAdminCheckTable is another kind of error, it means the admin check table fails because of the table data corruption.
Here we should report something like "unsupported operation", although the operation fails and returns error, the reason is different.
Signed-off-by: lihaowei <haoweili35@gmail.com>
|
/LGTM |
|
/lgtm |
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
ti-chi-bot
added
status/LGT2
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 6ffd9e2
|
ti-chi-bot
added
the
status/can-merge
|
/run-all-tests |
|
UT failed due to TestPrepareCacheForPartition. Reruning... |
|
/run-unit-test |
|
@Howie59: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
UT failed due to |
|
/run-unit-test |
What problem does this PR solve?
Issue Number: see #24168
What is changed and how it works?
Proposal: temporary table
What's Changed: add admin checksum table compatibility for temporary table
Check List
Tests
Release note