Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infoschema, executor, txn: change some field name in TIDB_TRX table #25061

Merged
merged 8 commits into from
Jun 3, 2021

Conversation

longfangsong
Copy link
Contributor

What problem does this PR solve?

Problem Summary:
Some field names in TIDB_TRX table are not very easy to understand.

What is changed and how it works?

What's Changed:

Change COUNT into MEM_BUFFER_KEYS and LEN into MEM_BUFFER_BYTES.

Check List

Tests

  • No code

Release note

  • No release note.

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 2, 2021
@longfangsong
Copy link
Contributor Author

/cc @MyonKeminta

@ti-chi-bot ti-chi-bot requested a review from MyonKeminta June 2, 2021 10:18
@longfangsong
Copy link
Contributor Author

/cc @MyonKeminta

@github-actions github-actions bot added the sig/sql-infra SIG: SQL Infra label Jun 2, 2021
@ti-chi-bot
Copy link
Member

@MyonKeminta: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@MyonKeminta MyonKeminta requested a review from cfzjywxk June 2, 2021 13:29
@MyonKeminta MyonKeminta added the sig/transaction SIG:Transaction label Jun 2, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 2, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • MyonKeminta
  • youjiali1995

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 3, 2021
@youjiali1995
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a901ed8

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 3, 2021
@MyonKeminta
Copy link
Contributor

/merge

2 similar comments
@MyonKeminta
Copy link
Contributor

/merge

@MyonKeminta
Copy link
Contributor

/merge

@MyonKeminta
Copy link
Contributor

/merge

@Rustin170506
Copy link
Member

/merge

@MyonKeminta You don't need to /merge as often, and if a test fails, you only need to run the test that failed. The bot will automatically merge PRs when all tests pass. there is no need to use /merge to trigger all tests.

@MyonKeminta
Copy link
Contributor

/run-integration-common-test

@ti-chi-bot
Copy link
Member

@longfangsong: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 6900a46 into pingcap:master Jun 3, 2021
@MyonKeminta MyonKeminta mentioned this pull request Jun 7, 2021
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/sql-infra SIG: SQL Infra sig/transaction SIG:Transaction size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants