Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: skip unstable test case TestMergeJoinInDisk and TestAnalyzeIndexExtractTopN. #25170

Merged
merged 4 commits into from
Jun 4, 2021

Conversation

bb7133
Copy link
Member

@bb7133 bb7133 commented Jun 4, 2021

What problem does this PR solve?

Issue Number: related to #25157

Problem Summary:

What's Changed: the unstable test cases are skipped temporarily.

How it Works:

Related changes

Check List

Tests

  • NA

Release note

  • No release note

@bb7133 bb7133 requested a review from a team as a code owner June 4, 2021 11:57
@bb7133 bb7133 requested review from lzmhhh123 and removed request for a team June 4, 2021 11:57
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 4, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 4, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hi-rustin
  • youjiali1995

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 4, 2021
@youjiali1995
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 87791b872ae6f1b6018e558fc182a4c8c5a47415

@Rustin170506
Copy link
Member

/merge

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 4, 2021
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jun 4, 2021
@bb7133 bb7133 changed the title executor: skip unstable test case TestMergeJoinInDisk. executor: skip unstable test case TestMergeJoinInDisk and TestAnalyzeIndexExtractTopN. Jun 4, 2021
@Rustin170506
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: dd15f0e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 4, 2021
@ti-chi-bot
Copy link
Member

@bb7133: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@github-actions github-actions bot added the sig/execution SIG execution label Jun 4, 2021
@zhouqiang-cl zhouqiang-cl merged commit 38e2fae into pingcap:master Jun 4, 2021
@bb7133 bb7133 deleted the bb7133/skip_unstable branch June 5, 2021 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants