Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: add history read compatibility for temporary table #25237

Merged
merged 7 commits into from
Jun 9, 2021
Merged

executor: add history read compatibility for temporary table #25237

merged 7 commits into from
Jun 9, 2021

Conversation

lcwangchao
Copy link
Collaborator

What problem does this PR solve?

add history read compatibility for temporary table

What is changed and how it works?

check variable tidb_snapshot when performing read for temporary table

Related changes

  • N/A

Check List

Tests

  • Unit test

Side effects

  • N/A

Release note

  • No release note

@lcwangchao lcwangchao requested a review from a team as a code owner June 8, 2021 06:37
@lcwangchao lcwangchao requested review from XuHuaiyu and removed request for a team June 8, 2021 06:37
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 8, 2021
@github-actions github-actions bot added the sig/execution SIG execution label Jun 8, 2021
@lcwangchao
Copy link
Collaborator Author

/run-check_dev_2

@ti-chi-bot
Copy link
Member

@djshow832: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@djshow832 djshow832 added the sig/sql-infra SIG: SQL Infra label Jun 9, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 9, 2021
@lcwangchao
Copy link
Collaborator Author

/run-check_dev_2

tiancaiamao
tiancaiamao reviewed Jun 9, 2021
View reviewed changes
Copy link
Contributor

@tiancaiamao tiancaiamao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

executor/executor_test.go Outdated
tk.MustExec("create global temporary table tmp1 " +
"(id int not null primary key, code int not null, value int default null, unique key code(code))" +
"on commit delete rows")
time.Sleep(time.Second)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the purpose of this Sleep()? to make the CI slower?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it runs to fast, timestamp NOW() will return a smaller ts than ts which was used by create table because NOW() has a second precision. I'll remove time.Sleep and change NOW() to NOW(6)

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • djshow832
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 9, 2021
@tiancaiamao
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 57249b4

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 9, 2021
@ti-chi-bot
Copy link
Member

@lcwangchao: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@lcwangchao
Copy link
Collaborator Author

/run-check_dev_2

@lcwangchao
Copy link
Collaborator Author

/run-integration-br-test

@lcwangchao
Copy link
Collaborator Author

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit d5a0d17 into pingcap:master Jun 9, 2021
@lcwangchao lcwangchao deleted the tmp_history_read branch June 9, 2021 05:18
@djshow832 djshow832 mentioned this pull request Jun 9, 2021
Closed
89 tasks
@guo-shaoge guo-shaoge removed the request for review from XuHuaiyu June 10, 2021 01:54
tiancaiamao pushed a commit to tiancaiamao/tidb that referenced this pull request Jun 23, 2021
@lcwangchao @tiancaiamao
executor: add history read compatibility for temporary table (pingcap…
9bff3ea 
…#25237)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djshow832 djshow832 djshow832 approved these changes

@tiancaiamao tiancaiamao tiancaiamao approved these changes

Assignees
No one assigned
Labels
sig/execution SIG execution sig/sql-infra SIG: SQL Infra size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lcwangchao @ti-chi-bot @tiancaiamao @djshow832