-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner/core: change agg cost factor (#25210) #25241
planner/core: change agg cost factor (#25210) #25241
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
/run-all-tests |
@hanfei1991 you're already a collaborator in bot's repo. |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: db75bb5
|
@ti-srebot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/run-check_dev |
cherry-pick #25210 to release-5.0
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/25241
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Problem Summary:
Right now the cost factor of only-group-by (always transformed from
select distinct ....
) statements is 1.0, leading to not pushing down agg in pseodu stats senerios. However, the cost factor is not reasonable to set 1.0 while the first-row's cost factor is only 0.1. This results in some unexpected behaviours, such as:It's hard to say which one is better because of the lack of stats info. But at least keeping same behaviours will not cause perils. In some MPP senarios, such as every complicated sql, the plans closer to the root (TiDB) might miss the stats info and choose 1-phase aggregation. Considering 2-phase agg is better than 1-phase in most cases, I think this change is beneficial.
However, we still need some experiments and reliable tests to calibrate the cost factors. This work should be done in the near future.
What is changed and how it works?
What's Changed:
change the factor of only-group-by agg from 1.0 to 0.1, which is same as first-row.
Tests
Release note