Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: fix wrong aggregate pruning for some cases #25289

Merged
merged 3 commits into from
Jun 16, 2021
Merged

planner: fix wrong aggregate pruning for some cases #25289

merged 3 commits into from
Jun 16, 2021

Conversation

lzmhhh123
Copy link
Contributor

Signed-off-by: lzmhhh123 lzmhhh123@gmail.com

What problem does this PR solve?

Issue Number: close #25202

What is changed and how it works?

How it Works:

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • Performance regression
    • Consumes more CPU

Release note

  • fix wrong aggregate pruning for some cases

@lzmhhh123
planner: fix wrong aggregate pruning for some cases
a1b83f8 
Signed-off-by: lzmhhh123 <lzmhhh123@gmail.com>
@lzmhhh123 lzmhhh123 requested a review from a team as a code owner June 9, 2021 05:47
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 9, 2021
@ichn-hu ichn-hu mentioned this pull request Jun 9, 2021
Closed
@lzmhhh123 lzmhhh123 requested review from wshwsh12 and removed request for eurekaka June 15, 2021 07:21
winoros
winoros reviewed Jun 15, 2021
View reviewed changes
planner/core/rule_column_pruning.go
@@ -106,7 +109,7 @@ func (la *LogicalAggregation) PruneColumns(parentUsedCols []*expression.Column)
aggrFunc.OrderByItems, cols = pruneByItems(aggrFunc.OrderByItems)
selfUsedCols = append(selfUsedCols, cols...)
}
if len(la.AggFuncs) == 0 {
if len(la.AggFuncs) == 0 || (!allFirstRow && allRemainFirstRow) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add comments why we need to add this check

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments are below this line.
https://github.com/pingcap/tidb/pull/25289/files#diff-ae586e551e5a201a40c83192b7dc23cc2778739ef522fcb02e4fb7fac2125c99R113

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 15, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • rebelice
  • winoros

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 16, 2021
@winoros
Copy link
Member

winoros commented Jun 16, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8046a06

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 16, 2021
@ti-chi-bot ti-chi-bot merged commit cea06b3 into pingcap:master Jun 16, 2021
@ti-srebot ti-srebot mentioned this pull request Jun 16, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #25471

@lzmhhh123 lzmhhh123 deleted the bug-fix/fix_prune_agg_col branch June 16, 2021 06:52
@lzmhhh123
Copy link
Contributor Author

/run-cherry-picker

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jun 16, 2021
@lzmhhh123 @ti-srebot
cherry pick pingcap#25289 to release-5.1
6edf062 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 16, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #25499

ti-chi-bot pushed a commit that referenced this pull request Jun 18, 2021
@ti-srebot
planner: fix wrong aggregate pruning for some cases (#25289) (#25499)
33d4dbc
@eurekaka eurekaka mentioned this pull request Jun 29, 2021
Closed
lzmhhh123 added a commit to ti-srebot/tidb that referenced this pull request Jun 30, 2021
@lzmhhh123
planner: fix wrong aggregate pruning for some cases (pingcap#25289)
65e8eb1
ti-chi-bot pushed a commit that referenced this pull request Jun 30, 2021
@ti-srebot
planner: fix wrong aggregate pruning for some cases (#25289) (#25471)
6312cee
@lzmhhh123
Copy link
Contributor Author

/run-cherry-picker

@ti-srebot ti-srebot mentioned this pull request Jul 8, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #26033

lzmhhh123 added a commit to ti-srebot/tidb that referenced this pull request Jul 14, 2021
@lzmhhh123
planner: fix wrong aggregate pruning for some cases (pingcap#25289)
4723fdc 
Signed-off-by: lzmhhh123 <lzmhhh123@gmail.com>
ti-chi-bot pushed a commit that referenced this pull request Jul 14, 2021
@ti-srebot
planner: fix wrong aggregate pruning for some cases (#25289) (#26033)
4a6db53
@lcwangchao lcwangchao mentioned this pull request Nov 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rebelice rebelice rebelice approved these changes

@winoros winoros winoros approved these changes

@wshwsh12 wshwsh12 Awaiting requested review from wshwsh12

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dml: wrong result in subquery with order by clause
5 participants
@lzmhhh123 @ti-chi-bot @winoros @ti-srebot @rebelice