Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner/core: fix bug that injected proj get wrong index. #25336

Merged
merged 7 commits into from
Jun 11, 2021
Merged

planner/core: fix bug that injected proj get wrong index. #25336

merged 7 commits into from
Jun 11, 2021

Conversation

hanfei1991
Copy link
Member

What problem does this PR solve?

Problem Summary:
Injected proj below union don't resolve index.

What is changed and how it works?

resolve it

Related changes

Check List

Tests

  • Unit test

Release note

  • planner/core: fix bug that injected proj get wrong index.

@hanfei1991 hanfei1991 requested review from a team as code owners June 10, 2021 08:49
@hanfei1991 hanfei1991 requested review from qw4990 and removed request for a team June 10, 2021 08:49
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 10, 2021
@github-actions github-actions bot added the sig/execution SIG execution label Jun 10, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 10, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qw4990
  • winoros

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 10, 2021
@hanfei1991
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 41e06a2

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 11, 2021
@hanfei1991
Copy link
Member Author

/run-all-tests

1 similar comment
@hanfei1991
Copy link
Member Author

/run-all-tests

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jun 11, 2021
@hanfei1991
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2762103

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 11, 2021
@hanfei1991
Copy link
Member Author

/run-integration-common-test

@ti-chi-bot ti-chi-bot merged commit b76d467 into pingcap:master Jun 11, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jun 11, 2021
@hanfei1991 @ti-srebot
cherry pick pingcap#25336 to release-5.0
d10647a 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 11, 2021
Closed
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #25360

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jun 11, 2021
@hanfei1991 @ti-srebot
cherry pick pingcap#25336 to release-5.1
ba83134 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 11, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #25361

@longccc1c longccc1c mentioned this pull request Jun 11, 2021
Open
ti-chi-bot pushed a commit that referenced this pull request Jun 11, 2021
@ti-srebot
planner/core: fix bug that injected proj get wrong index. (#25336) (#…
f1bd5f3 
…25361)
hanfei1991 added a commit to ti-srebot/tidb that referenced this pull request Jun 15, 2021
@hanfei1991
planner/core: fix bug that injected proj get wrong index. (pingcap#25336
cd8fe22 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros approved these changes

@qw4990 qw4990 qw4990 approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 sig/execution SIG execution size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hanfei1991 @ti-chi-bot @ti-srebot @qw4990 @winoros