-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: Log warnings when agg function can not be pushdown in explain statement #25553
Merged
ti-chi-bot
merged 14 commits into
pingcap:master
from
windtalker:agg_not_pushdown_warnings
Jun 24, 2021
Merged
Changes from 8 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
90dade1
add warnings when agg is not able to push down to storage layer
windtalker f3dae65
Merge branch 'master' of https://github.com/pingcap/tidb into agg_not…
windtalker bc5654e
merge master
windtalker 4ae25e9
refine
windtalker 6f2b74c
Merge branch 'master' of https://github.com/pingcap/tidb into agg_not…
windtalker 9fad8c7
Merge branch 'master' of https://github.com/pingcap/tidb into agg_not…
windtalker b024e7f
Merge branch 'master' of https://github.com/pingcap/tidb into agg_not…
windtalker b350073
add tests
windtalker 20aa519
Merge branch 'master' of https://github.com/pingcap/tidb into agg_not…
windtalker a0387d6
add more tests
windtalker 1bce974
add more tests
windtalker 0300490
update tests
windtalker c82174c
merge master
windtalker 23e3fcc
fix ci
windtalker File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what if the unsupported function occur in group by?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and distinct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add tests about groupBy and distinct.