Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: fix incorrect result of set type for merge join #25672

Merged
merged 2 commits into from
Jun 23, 2021
Merged

planner: fix incorrect result of set type for merge join #25672

merged 2 commits into from
Jun 23, 2021

Conversation

wshwsh12
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #25669

Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:

How it Works:
Avoid merge join using set index.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note

  • Fix incorrect result of set type for merge join

@wshwsh12 wshwsh12 requested review from a team as code owners June 22, 2021 10:03
@wshwsh12 wshwsh12 requested review from qw4990 and removed request for a team June 22, 2021 10:03
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 22, 2021
@wshwsh12 wshwsh12 requested a review from XuHuaiyu June 22, 2021 10:04
@github-actions github-actions bot added the sig/execution SIG execution label Jun 22, 2021
@XuHuaiyu XuHuaiyu added the type/bugfix This PR fixes a bug. label Jun 22, 2021
XuHuaiyu
XuHuaiyu reviewed Jun 22, 2021
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 22, 2021
@ichn-hu ichn-hu mentioned this pull request Jun 22, 2021
Closed
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • XuHuaiyu
  • qw4990

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 23, 2021
@qw4990
Copy link
Contributor

qw4990 commented Jun 23, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c058bd2

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 23, 2021
@ti-chi-bot ti-chi-bot merged commit 574de5e into pingcap:master Jun 23, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jun 23, 2021
@wshwsh12 @ti-srebot
cherry pick pingcap#25672 to release-5.0
67568c7 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 23, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #25694

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jun 23, 2021
@wshwsh12 @ti-srebot
cherry pick pingcap#25672 to release-5.1
b769971 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 23, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #25695

ti-chi-bot pushed a commit that referenced this pull request Jun 25, 2021
@ti-srebot
planner: fix incorrect result of set type for merge join (#25672) (#2…
9d94645 
…5694)
@lzmhhh123
Copy link
Contributor

/run-cherry-picker

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 8, 2021
@wshwsh12 @ti-srebot
cherry pick pingcap#25672 to release-4.0
d564a20 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 8, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #26032

ti-chi-bot pushed a commit that referenced this pull request Jul 14, 2021
@ti-srebot
planner: fix incorrect result of set type for merge join (#25672) (#2…
831cad0 
…6032)
ti-chi-bot pushed a commit that referenced this pull request Jul 19, 2021
@ti-srebot
planner: fix incorrect result of set type for merge join (#25672) (#2…
d9e61d5 
…5695)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

@qw4990 qw4990 qw4990 approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 sig/execution SIG execution sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wrong join result of set type
6 participants
@wshwsh12 @ti-chi-bot @qw4990 @ti-srebot @lzmhhh123 @XuHuaiyu