Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

region_cache: filter peers on tombstone or dropped stores (#24726) #25839

Merged
merged 2 commits into from
Jun 30, 2021
Merged

region_cache: filter peers on tombstone or dropped stores (#24726) #25839

merged 2 commits into from
Jun 30, 2021

Conversation

youjiali1995
Copy link
Contributor

What problem does this PR solve?

Problem Summary:
Backport some bug fixes.

What is changed and how it works?

What's Changed:
Cherry-pick #23695 and #24726.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Side effects

Release note

  • Fix the issue that sometimes fails to send requests if there are tombstone stores.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 30, 2021
@youjiali1995 youjiali1995 changed the title Cherry pick 24726 5 region_cache: filter peers on tombstone or dropped stores (#24726) Jun 30, 2021
@youjiali1995
Copy link
Contributor Author

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Jun 30, 2021

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what's changed

Or if the count of mainly changed packages are more than 3, use

  • *: what's changed

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 30, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • longfangsong
  • sticnarf

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 30, 2021
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Jun 30, 2021
@zhouqiang-cl
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: de6eb55

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 30, 2021
@ti-chi-bot ti-chi-bot merged commit ac6d86b into pingcap:release-5.0 Jun 30, 2021
@youjiali1995 youjiali1995 mentioned this pull request Jun 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sticnarf sticnarf sticnarf approved these changes

@longfangsong longfangsong longfangsong approved these changes

@lysu lysu Awaiting requested review from lysu

Assignees
No one assigned
Labels
cherry-pick-approved Cherry pick PR approved by release team. sig/transaction SIG:Transaction size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/5.0-cherry-pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@youjiali1995 @sre-bot @ti-chi-bot @zhouqiang-cl @longfangsong @sticnarf