-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
util/stmtsummary: discard the plan if it is too long and enlarge the tidb_stmt_summary_max_stmt_count value to 3000 (#25843) #25872
util/stmtsummary: discard the plan if it is too long and enlarge the tidb_stmt_summary_max_stmt_count value to 3000 (#25843) #25872
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
/run-all-tests |
@crazycs520 you're already a collaborator in bot's repo. |
@crazycs520 Please fix merge conflicts. |
Signed-off-by: crazycs <crazycs520@gmail.com>
/run-all-tests |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 9b061c5
|
/merge |
cherry-pick #25843 to release-4.0
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/25872
After apply modifications, you can push your change to this PR via:
Signed-off-by: crazycs crazycs520@gmail.com
What problem does this PR solve?
Currently
statements_summary
doesn't restrict the plan size, in some extreme scenarios, TIDB might OOM. This PR discards thestatements_summary
plan if it is too long (encode plan size more than 1MB) to avoid occupies too much memory.Enlarge
tidb_stmt_summary_max_stmt_count
default value from 200 to 3000. Since 200 is too small when troubleshooting.What is changed and how it works?
About Enlarge
tidb_stmt_summary_max_stmt_count
default value, this doc record the test process. The final conclusion is:Enlarge the
tidb_stmt_summary_max_stmt_count
default value to 3000:Related changes
pingcap/docs
/pingcap/docs-cn
:Check List
Tests
Side effects
Release note