Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: fix unstable test TestExprOnlyPushDownToFlash #25952

Merged
merged 8 commits into from
Jul 5, 2021

Conversation

LittleFall
Copy link
Contributor

@LittleFall LittleFall commented Jul 5, 2021

What problem does this PR solve?

Issue Number: close #25584, partially #25899

Problem Summary: see #25584 (comment)

What is changed and how it works?

What's Changed: remove functions about blacklist here.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn: no need
  • Need to cherry-pick to the release branch: no need

Check List

Tests

  • Integration test
  • Manual test (add detailed scripts or steps below)

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note

  • No release note

@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 5, 2021
@LittleFall
Copy link
Contributor Author

/run-unit-test

4 similar comments
@LittleFall
Copy link
Contributor Author

/run-unit-test

@LittleFall
Copy link
Contributor Author

/run-unit-test

@LittleFall
Copy link
Contributor Author

/run-unit-test

@LittleFall
Copy link
Contributor Author

/run-unit-test

@LittleFall
Copy link
Contributor Author

/run-unit-test

@ti-chi-bot ti-chi-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 5, 2021
@LittleFall LittleFall changed the title DNM: try to find unstable test expression: fix unstable test TestExprOnlyPushDownToFlash Jul 5, 2021
@ti-chi-bot
Copy link
Member

@fzhedu: Please use GitHub review feature instead of /lgtm [cancel] when you want to submit review to the pull request.
For how to use GitHub review feature, see also this document provided by GitHub.

For the reason we drop support to the commands, see also this page.
This reply is being used as a temporary reply during the migration of review process and will be removed on July 1st.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

@fzhedu fzhedu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 5, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • fzhedu
  • lzmhhh123

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 5, 2021
@LittleFall
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 4ed2915

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 5, 2021
@ichn-hu ichn-hu mentioned this pull request Jul 5, 2021
This reverts commit fbca983.
This reverts commit 4ed2915.
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jul 5, 2021
@LittleFall
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2b6e91e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 5, 2021
@ti-chi-bot ti-chi-bot merged commit 7259784 into pingcap:master Jul 5, 2021
@LittleFall
Copy link
Contributor Author

The result of the attempt shows: test suite with bootstrap such as testIntegrationSuiteBase will initialize the blacklist, and will not eliminate it after teardown.

If the suite tested of TestExprOnlyPushDownToFlash is set to serial, then this error will inevitably occur. The minimum recurrence is: go test -v ./expression/... -check.f "TestExprPushdownBlacklist|TestExprOnlyPushDownToFlash".

Another solution is to manually eliminate the blacklist when every suite is tearing down.

	tk := testkit.NewTestKit(c, s.store)
	tk.MustExec("use mysql")
	tk.MustExec("delete from expr_pushdown_blacklist")
	tk.MustExec("admin reload expr_pushdown_blacklist")

but it is too stupid.

@LittleFall LittleFall deleted the bugfix/unstable-test branch July 5, 2021 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unstable test testEvaluatorSuite.TestExprOnlyPushDownToFlash
4 participants