-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: fix unstable test TestExprOnlyPushDownToFlash #25952
Conversation
/run-unit-test |
4 similar comments
/run-unit-test |
/run-unit-test |
/run-unit-test |
/run-unit-test |
This reverts commit 2e9a297.
/run-unit-test |
a1ba4a2
to
13e9639
Compare
@fzhedu: Please use GitHub review feature instead of For the reason we drop support to the commands, see also this page. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM
This reverts commit 13e9639.
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 4ed2915
|
b4f8c38
to
4ac2e69
Compare
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 2b6e91e
|
The result of the attempt shows: test suite with bootstrap such as If the suite tested of Another solution is to manually eliminate the blacklist when every suite is tearing down.
but it is too stupid. |
What problem does this PR solve?
Issue Number: close #25584, partially #25899
Problem Summary: see #25584 (comment)
What is changed and how it works?
What's Changed: remove functions about blacklist here.
Related changes
pingcap/docs
/pingcap/docs-cn
: no needCheck List
Tests
Side effects
Release note