Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: stop DDL retry when partition ID is not found in truncate partition (#26232) #26238

Merged
merged 4 commits into from
Sep 2, 2021

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Jul 14, 2021

cherry-pick #26232 to release-5.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/26238

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/26238:release-5.0-1ecae3d1d880

What problem does this PR solve?

Issue Number: close #26229

Problem Summary:

Before this PR, TRUNCATE PARTITION DDL job use partition ID as the job argument.

Since the truncating implementation is to drop old partition and then add a new partition, the partition ID is changed between two
job. However, it is possible that there are 2 same "truncate" job occurs in the DDL job queue, because they are enqueued by different TiDB server.

In this case, the argument(partition ID) of the second job becomes invalid. Finally the error 'partition not found' is reported.

What is changed and how it works?

What's Changed: Use partition name instead of ID as the job argument.

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • Performance regression: Consumes more Memory

Documentation

NA

Release note

  • Fix the issue that concurrently truncating the same partition hangs DDL.

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 14, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • djshow832
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot added sig/sql-infra SIG: SQL Infra size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/5.0-cherry-pick labels Jul 14, 2021
@ti-srebot ti-srebot added this to the v5.0.3 milestone Jul 14, 2021
@ti-srebot
Copy link
Contributor Author

@tangenta you're already a collaborator in bot's repo.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 27, 2021
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 30, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 2, 2021
@djshow832
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 5023da1

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 2, 2021
@ti-chi-bot
Copy link
Member

@ti-srebot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 0a18ae2 into pingcap:release-5.0 Sep 2, 2021
@zhouqiang-cl zhouqiang-cl removed this from the v5.0.3 milestone Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. sig/sql-infra SIG: SQL Infra size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/5.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants