planner: add warnings about joins when tidb_enforce_mpp is enabled. #26246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
added
the
size/XXL
hanfei1991
approved these changes
Jul 14, 2021
ti-chi-bot
added
size/XL
windtalker
reviewed
Jul 14, 2021
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
status/LGT2
LittleFall
force-pushed
the
enhance/join-warnings
branch
from
d13884f
to
4eceff6
Compare
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: f7b5c00
|
ti-chi-bot
added
the
status/can-merge
|
/run-cherry-picker |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Jul 15, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
10 tasks
|
cherry pick to release-5.1 in PR #26272 |
LittleFall
added a commit
to LittleFall/tidb
that referenced
this pull request
Jul 20, 2021
10 tasks
LittleFall
added a commit
to LittleFall/tidb
that referenced
this pull request
Jul 20, 2021
This was referenced Jul 20, 2021
ti-chi-bot
pushed a commit
that referenced
this pull request
Jul 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close pingcap/tiflash#1905
Problem Summary: This is the follow-up of #25302, add warnings when tidb_enforce_mpp is enabled but mpp is blocked.
What is changed and how it works?
What's Changed: adding warnings for join.
How it Works:
Check List
Tests
Side effects
Documentation
Release note