planner/core: always add projection to agg that is pushed to tiflash #26263
Conversation
ti-chi-bot
added
the
size/M
| @@ -279,6 +279,7 @@ | |||
| "desc format = 'brief' select /*+hash_agg()*/ sum(id) from (select value, id from t where id > value group by id, value)A group by value /*the exchange should have only one partition column: test.t.value*/", | |||
| "desc format = 'brief' select /*+hash_agg()*/ sum(B.value) from t as B where B.id+1 > (select count(*) from t where t.id= B.id and t.value=B.value) group by B.id /*the exchange should have only one partition column: test.t.id*/", | |||
| "desc format = 'brief' select count(distinct value) from t", | |||
| "desc format = 'brief' select count(distinct x ) from (select count(distinct value) x from t) t", | |||
There was a problem hiding this comment.
would we add a test case : select count(distinct x), avg(y) ? becase avg would add a proj.
There was a problem hiding this comment.
the test case below this one is exactly what you mentioned
|
/run_check_dev_2 |
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
status/LGT2
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 34f05fd
|
ti-chi-bot
added
the
status/can-merge
|
/merge |
|
/run_check_dev_2 |
What problem does this PR solve?
Problem Summary: After implementing count-distinct agg totally push-down, sometimes agg's parent will be a non-projection, which results in unexpected error on TiFlash.
What is changed and how it works?
What's Changed:
We fix it by always adding a projection for scalar agg that is pushed down.
Check List
Tests
Side effects
Documentation
Release note