-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: ingore locks of temporary table for point_get/batch_point_get/select_lock #26267
Conversation
No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: c3078ac
|
B.T.W, we need to prevent DDL change on local temporary table, or at least forbid that when temporary table data not empty. @lcwangchao |
@lcwangchao: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This is a issue in todo list: #25888 |
/run-unit-test |
executor: ingore locks of temporary table for point_get/batch_point_get/select_lock
What problem does this PR solve?
Problem Summary:
Because temporary tables only store records in memory and not share data with other session, so it is unnecessary to do locks. However, we just filtered temporary keys for insert/update/delete, just select for update will still write locks to tikv.
Moreover "select ... for update" still introduces some side effects to temporary table. For example, temporary table should not check schema version when committed. But if you just execute "select for update" in temporary table now, it will return an error when schema version changed.
What is changed and how it works?
Set lock vairable for PointGetExecutor#lock/PointGetExecutor#lock to false if it is a temporary table. And in SelectLockExec, filter out temporary table handles. After that not any locks will be written to tikv and can also avoid side effects introduced by locks (like schema version checking).
Check List
Tests
Side effects
Release note