Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: ingore locks of temporary table for point_get/batch_point_get/select_lock #26267

Merged
merged 10 commits into from
Jul 15, 2021

Conversation

lcwangchao
Copy link
Collaborator

@lcwangchao lcwangchao commented Jul 15, 2021

executor: ingore locks of temporary table for point_get/batch_point_get/select_lock

What problem does this PR solve?

Problem Summary:

Because temporary tables only store records in memory and not share data with other session, so it is unnecessary to do locks. However, we just filtered temporary keys for insert/update/delete, just select for update will still write locks to tikv.

Moreover "select ... for update" still introduces some side effects to temporary table. For example, temporary table should not check schema version when committed. But if you just execute "select for update" in temporary table now, it will return an error when schema version changed.

What is changed and how it works?

Set lock vairable for PointGetExecutor#lock/PointGetExecutor#lock to false if it is a temporary table. And in SelectLockExec, filter out temporary table handles. After that not any locks will be written to tikv and can also avoid side effects introduced by locks (like schema version checking).

Check List

Tests

  • Unit test

Side effects

  • N/A

Release note

  • No release note

@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 15, 2021
@ti-srebot
Copy link
Contributor

@github-actions github-actions bot added sig/execution SIG execution sig/sql-infra SIG: SQL Infra labels Jul 15, 2021
session/session_test.go Outdated Show resolved Hide resolved
session/session_test.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 15, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 15, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • djshow832
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 15, 2021
@tiancaiamao
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c3078ac

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 15, 2021
@tiancaiamao
Copy link
Contributor

B.T.W, we need to prevent DDL change on local temporary table, or at least forbid that when temporary table data not empty. @lcwangchao

@ti-chi-bot
Copy link
Member

@lcwangchao: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@lcwangchao
Copy link
Collaborator Author

B.T.W, we need to prevent DDL change on local temporary table, or at least forbid that when temporary table data not empty. @lcwangchao

This is a issue in todo list: #25888

@lcwangchao
Copy link
Collaborator Author

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit 35e19ef into pingcap:master Jul 15, 2021
@lcwangchao lcwangchao deleted the temporary_for_udpate branch July 15, 2021 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution sig/sql-infra SIG: SQL Infra size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants