Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: Implement batch point get for local temporary table #26290

Merged
merged 8 commits into from
Jul 19, 2021
Merged

executor: Implement batch point get for local temporary table #26290

merged 8 commits into from
Jul 19, 2021

Conversation

lcwangchao
Copy link
Collaborator

What problem does this PR solve?

Issue Number: close #26050

Implement batch point get for local temporary table

What is changed and how it works?

rename globalTemporaryTableSnapshot to temporaryTableSnapshot and used for all temporay tables

Check List

Tests

  • Unit test

Release note

  • No release note

@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 16, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 16, 2021
@github-actions github-actions bot added sig/execution SIG execution sig/sql-infra SIG: SQL Infra labels Jul 16, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • djshow832
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 19, 2021
@tiancaiamao
Copy link
Contributor

A special case might be the update operator using batch point get...
Because there are both read and write from the membuffer in that case.

@tiancaiamao
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: bb4f097

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 19, 2021
@ti-chi-bot ti-chi-bot merged commit 2f028b3 into pingcap:master Jul 19, 2021
@lcwangchao
Copy link
Collaborator Author

A special case might be the update operator using batch point get...
Because there are both read and write from the membuffer in that case.

Yes, this case will be tested after #26051 completed

@lcwangchao lcwangchao deleted the local_table_batch_point_get branch July 19, 2021 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djshow832 djshow832 djshow832 approved these changes

@tiancaiamao tiancaiamao tiancaiamao approved these changes

Assignees
No one assigned
Labels
sig/execution SIG execution sig/sql-infra SIG: SQL Infra size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support batch point get for temporary table
4 participants
@lcwangchao @ti-chi-bot @tiancaiamao @djshow832