Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metrics: fix copr-cache metrics #26339

Merged
merged 2 commits into from
Jul 19, 2021
Merged

metrics: fix copr-cache metrics #26339

merged 2 commits into from
Jul 19, 2021

Conversation

jackysp
Copy link
Member

@jackysp jackysp commented Jul 19, 2021 •
edited
Loading

Signed-off-by: Shuaipeng Yu jackysp@gmail.com

What problem does this PR solve?

Issue Number: close #26338

Problem Summary:
The metrics formula is wrong on Grafana.
截屏2021-07-19 下午2 45 33

What is changed and how it works?

Proposal: xxx

What's Changed:
Fix it as a counter.

How it Works:

Check List

Tests

Release note

  • Fix copt-cache metrics, it will display the number of hits/miss/evict on Grafana.

@jackysp
metrics: fix copr-cache metrics
ebcc42a 
Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 19, 2021
@jackysp
Copy link
Member Author

jackysp commented Jul 19, 2021

/run-monitor-test

@jackysp
Copy link
Member Author

jackysp commented Jul 19, 2021

/run-monitor-test

Its server may be down, PTAL @zhouqiang-cl .

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 19, 2021
@breezewish
Copy link
Member

/run-all-tests

@breezewish
Copy link
Member

@lzmhhh123 PTAL

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • breeswish
  • lzmhhh123

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 19, 2021
@lzmhhh123
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ebcc42a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 19, 2021
@ti-chi-bot ti-chi-bot merged commit 53f15f1 into pingcap:master Jul 19, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 19, 2021
@jackysp @ti-srebot
cherry pick pingcap#26339 to release-4.0
f8ef025 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 19, 2021
Merged
1 task
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #26342

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 19, 2021
@jackysp @ti-srebot
cherry pick pingcap#26339 to release-5.0
f23883e 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 19, 2021
Merged
1 task
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #26343

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 19, 2021
@jackysp @ti-srebot
cherry pick pingcap#26339 to release-5.1
78051aa 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 19, 2021
Merged
1 task
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #26344

ti-chi-bot pushed a commit that referenced this pull request Jul 22, 2021
@ti-srebot
metrics: fix copr-cache metrics (#26339) (#26344)
1114e41
ti-chi-bot pushed a commit that referenced this pull request Sep 2, 2021
@ti-srebot
metrics: fix copr-cache metrics (#26339) (#26343)
3bb7f41
ti-chi-bot pushed a commit that referenced this pull request Nov 19, 2021
@ti-srebot
metrics: fix copr-cache metrics (#26339) (#26342)
15580cc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzmhhh123 lzmhhh123 lzmhhh123 approved these changes

@breezewish breezewish breezewish approved these changes

Assignees
No one assigned
Labels
component/metrics needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Copr-cache metrics on TiDB have no data
5 participants
@jackysp @breezewish @ti-chi-bot @lzmhhh123 @ti-srebot